Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update units to pass on macOS #60435

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Update units to pass on macOS #60435

merged 2 commits into from
Aug 12, 2019

Conversation

sivel
Copy link
Member

@sivel sivel commented Aug 12, 2019

SUMMARY

Update units to pass on macOS. Fixes #27810

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/units/

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 12, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 12, 2019

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 12, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 12, 2019
@@ -10,6 +10,7 @@ pytest
pytest-mock
pytest-xdist
python-memcached
pytz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What needs this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/units/module_utils/common/text/converters/test_json_encode_fallback.py
12:from pytz import timezone as tz

test/units/parsing/test_ajson.py
14:from pytz import timezone as tz

@sivel sivel merged commit 697b566 into ansible:devel Aug 12, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 13, 2019
@ansible ansible locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests fail on macOS
3 participants