Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update junos_facts gather_network_resources choices #60467

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Update junos_facts gather_network_resources choices #60467

merged 1 commit into from
Aug 14, 2019

Conversation

ganeshrn
Copy link
Member

SUMMARY
  • Add negation choice for individual resource names
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_facts

ADDITIONAL INFORMATION

@ganeshrn
Update junos_facts gather_network_resources choices
e2dc860 
*  Add negation choice for individual resource names
@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2019

cc @Qalthos
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Aug 13, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2019

cc @Qalthos
click here for bot help

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 13, 2019

Build succeeded (third-party-check pipeline).

danielmellado
danielmellado approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@danielmellado danielmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ganesh! It might be only useful to add a small note at the commit explaining the need for this!

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 14, 2019
@NilashishC NilashishC merged commit 5923a64 into ansible:devel Aug 14, 2019
@ansible ansible locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielmellado danielmellado danielmellado approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ganeshrn @ansibot @danielmellado @NilashishC