Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource module for ios_lldp_global #60506

Merged
merged 4 commits into from Aug 21, 2019
Merged

Resource module for ios_lldp_global #60506

merged 4 commits into from Aug 21, 2019

Conversation

justjais
Copy link
Contributor

SUMMARY

Resource module for ios_lldp_global, with supported operations and respective integration tests.
(ref model: ios_lldp_global model)

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ios_lldp_global

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies ios Cisco IOS community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Aug 13, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2019

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module ios_facts ios_interfaces ios_lldp_global" returned exit status 1.
>>> Standard Error
ERROR! module ios_lldp_global missing documentation (or could not parse documentation): while scanning a simple key
  in "<unicode string>", line 11, column 1
could not find expected ':'
  in "<unicode string>", line 12, column 1

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/ ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-keywords --template-dir=../templates --output-dir=rst/reference_appendices/ ./keyword_desc.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-plugins -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:98: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 88, in <module>
    main()
  File "../../hacking/build-ansible.py", line 79, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 698, in main
    plugin_info, categories = get_plugin_info(args.module_dir, limit_to=args.limit_to, verbose=(args.verbosity > 0))
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 225, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "ext/_yaml.pyx", line 707, in _yaml.CParser.get_single_node
  File "ext/_yaml.pyx", line 725, in _yaml.CParser._compose_document
  File "ext/_yaml.pyx", line 776, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 890, in _yaml.CParser._compose_mapping_node
  File "ext/_yaml.pyx", line 774, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 853, in _yaml.CParser._compose_sequence_node
  File "ext/_yaml.pyx", line 905, in _yaml.CParser._parse_next_event
yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 11, column 1
could not find expected ':'
  in "<unicode string>", line 12, column 1
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/facts/lldp_global/lldp_global.py:87:9: E303 too many blank lines (3)

The test ansible-test sanity --test validate-modules [explain] failed with 35 errors:

lib/ansible/modules/network/ios/ios_facts.py:0:0: E326 Argument 'gather_network_resources' in argument_spec defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces'], ['lldp_global'], ['!lldp_global']]) but documentation defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces']])
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'holdtime' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'mac_phy_cfg' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'management_address' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'port_description' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'port_vlan:' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'power_management' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'reinit' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'run' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'system_capabilities' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'system_description' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'system_name' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'timer' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'tlv_select' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E324 Argument 'state' in argument_spec defines default as ('merged') but documentation defines default as (None)
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['merged', 'replaced', 'deleted']) but documentation defines choices as ([])
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E336 Argument 'port_vlan:' in argument_spec found in config -> tlv_select is not a valid python identifier
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'config' in argument_spec defines type as 'list' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'holdtime' in argument_spec found in config defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'mac_phy_cfg' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'management_address' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'port_description' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'port_vlan:' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'power_management' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'reinit' in argument_spec found in config defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'run' in argument_spec found in config defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'system_capabilities' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'system_description' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'system_name' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'timer' in argument_spec found in config defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'tlv_select' in argument_spec found in config defines type as 'dict' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E340 Argument 'config' in argument_spec has sub-options but documentation does not define it
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E340 Argument 'tlv_select' in argument_spec found in config has sub-options but documentation does not define it
lib/ansible/modules/network/ios/ios_lldp_global.py:48:1: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_lldp_global.py:48:1: error DOCUMENTATION: syntax error: could not find expected ':'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @rcarrillocruz @trishnaguha
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 13, 2019

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module ios_facts ios_interfaces ios_lldp_global" returned exit status 1.
>>> Standard Error
ERROR! module ios_lldp_global missing documentation (or could not parse documentation): while scanning a simple key
  in "<unicode string>", line 11, column 1
could not find expected ':'
  in "<unicode string>", line 12, column 1

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/ ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-keywords --template-dir=../templates --output-dir=rst/reference_appendices/ ./keyword_desc.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-plugins -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:98: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 88, in <module>
    main()
  File "../../hacking/build-ansible.py", line 79, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 698, in main
    plugin_info, categories = get_plugin_info(args.module_dir, limit_to=args.limit_to, verbose=(args.verbosity > 0))
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 225, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "ext/_yaml.pyx", line 707, in _yaml.CParser.get_single_node
  File "ext/_yaml.pyx", line 725, in _yaml.CParser._compose_document
  File "ext/_yaml.pyx", line 776, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 890, in _yaml.CParser._compose_mapping_node
  File "ext/_yaml.pyx", line 774, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 853, in _yaml.CParser._compose_sequence_node
  File "ext/_yaml.pyx", line 905, in _yaml.CParser._parse_next_event
yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 11, column 1
could not find expected ':'
  in "<unicode string>", line 12, column 1
make: *** [modules] Error 1

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/facts/lldp_global/lldp_global.py:87:9: E303 too many blank lines (3)

The test ansible-test sanity --test validate-modules [explain] failed with 35 errors:

lib/ansible/modules/network/ios/ios_facts.py:0:0: E326 Argument 'gather_network_resources' in argument_spec defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces'], ['lldp_global'], ['!lldp_global']]) but documentation defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces']])
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'holdtime' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'mac_phy_cfg' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'management_address' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'port_description' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'port_vlan:' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'power_management' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'reinit' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'run' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'system_capabilities' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'system_description' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'system_name' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'timer' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'tlv_select' found in config is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E324 Argument 'state' in argument_spec defines default as ('merged') but documentation defines default as (None)
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['merged', 'replaced', 'deleted']) but documentation defines choices as ([])
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E336 Argument 'port_vlan:' in argument_spec found in config -> tlv_select is not a valid python identifier
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'config' in argument_spec defines type as 'list' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'holdtime' in argument_spec found in config defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'mac_phy_cfg' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'management_address' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'port_description' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'port_vlan:' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'power_management' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'reinit' in argument_spec found in config defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'run' in argument_spec found in config defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'system_capabilities' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'system_description' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'system_name' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'timer' in argument_spec found in config defines type as 'int' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'tlv_select' in argument_spec found in config defines type as 'dict' but documentation doesn't define type
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E340 Argument 'config' in argument_spec has sub-options but documentation does not define it
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E340 Argument 'tlv_select' in argument_spec found in config has sub-options but documentation does not define it
lib/ansible/modules/network/ios/ios_lldp_global.py:48:1: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_lldp_global.py:48:1: error DOCUMENTATION: syntax error: could not find expected ':'

click here for bot help

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 13, 2019

Build succeeded (third-party-check pipeline).

@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module ios_facts ios_interfaces ios_l2_interfaces ios_lacp ios_lacp_interfaces ios_lag_interfaces ios_lldp_global ios_vlans" returned exit status 1.
>>> Standard Error
ERROR! module ios_lldp_global missing documentation (or could not parse documentation): while scanning a simple key
  in "<unicode string>", line 11, column 1
could not find expected ':'
  in "<unicode string>", line 12, column 1

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/ ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-keywords --template-dir=../templates --output-dir=rst/reference_appendices/ ./keyword_desc.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-plugins -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:98: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 88, in <module>
    main()
  File "../../hacking/build-ansible.py", line 79, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 711, in main
    plugin_info, categories = get_plugin_info(args.module_dir, limit_to=args.limit_to, verbose=(args.verbosity > 0))
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 225, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "ext/_yaml.pyx", line 707, in _yaml.CParser.get_single_node
  File "ext/_yaml.pyx", line 725, in _yaml.CParser._compose_document
  File "ext/_yaml.pyx", line 776, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 890, in _yaml.CParser._compose_mapping_node
  File "ext/_yaml.pyx", line 774, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 853, in _yaml.CParser._compose_sequence_node
  File "ext/_yaml.pyx", line 905, in _yaml.CParser._parse_next_event
yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 11, column 1
could not find expected ':'
  in "<unicode string>", line 12, column 1
make: *** [modules] Error 1

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name dict_diff
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name dict_diff

The test ansible-test sanity --test import --python 2.7 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name dict_diff
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name dict_diff
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name dict_diff

The test ansible-test sanity --test import --python 3.5 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff'
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name 'dict_diff'
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff'
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name 'dict_diff'
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)

The test ansible-test sanity --test import --python 3.8 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/facts/lldp_global/lldp_global.py:87:9: E303 too many blank lines (3)

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_facts.py:0:0: E326 Argument 'gather_network_resources' in argument_spec defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces'], ['l2_interfaces'], ['!l2_interfaces'], ['vlans'], ['!vlans'], ['lag_interfaces'], ['!lag_interfaces'], ['lacp'], ['!lacp'], ['lacp_interfaces'], ['!lacp_interfaces'], ['lldp_global'], ['!lldp_global']]) but documentation defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces'], ['l2_interfaces'], ['!l2_interfaces'], ['vlans'], ['!vlans'], ['lag_interfaces'], ['!lag_interfaces'], ['lacp'], ['!lacp'], ['lacp_interfaces'], ['!lacp_interfaces']])
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'cannot import name 'dict_diff''
lib/ansible/modules/network/ios/ios_lldp_global.py:48:1: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_lldp_global.py:48:1: error DOCUMENTATION: syntax error: could not find expected ':'

click here for bot help

1 similar comment
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

The test ansible-test sanity --test ansible-doc [explain] failed with the error:

Command "ansible-doc -t module ios_facts ios_interfaces ios_l2_interfaces ios_lacp ios_lacp_interfaces ios_lag_interfaces ios_lldp_global ios_vlans" returned exit status 1.
>>> Standard Error
ERROR! module ios_lldp_global missing documentation (or could not parse documentation): while scanning a simple key
  in "<unicode string>", line 11, column 1
could not find expected ':'
  in "<unicode string>", line 12, column 1

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/ ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-keywords --template-dir=../templates --output-dir=rst/reference_appendices/ ./keyword_desc.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-plugins -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:98: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 88, in <module>
    main()
  File "../../hacking/build-ansible.py", line 79, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 711, in main
    plugin_info, categories = get_plugin_info(args.module_dir, limit_to=args.limit_to, verbose=(args.verbosity > 0))
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 225, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 111, in get_docstring
    data = read_docstring(filename, verbose=verbose, ignore_errors=ignore_errors)
  File "/root/ansible/lib/ansible/parsing/plugin_docs.py", line 59, in read_docstring
    data[varkey] = AnsibleLoader(child.value.s, file_name=filename).get_single_data()
  File "/usr/local/lib/python3.6/dist-packages/yaml/constructor.py", line 41, in get_single_data
    node = self.get_single_node()
  File "ext/_yaml.pyx", line 707, in _yaml.CParser.get_single_node
  File "ext/_yaml.pyx", line 725, in _yaml.CParser._compose_document
  File "ext/_yaml.pyx", line 776, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 890, in _yaml.CParser._compose_mapping_node
  File "ext/_yaml.pyx", line 774, in _yaml.CParser._compose_node
  File "ext/_yaml.pyx", line 853, in _yaml.CParser._compose_sequence_node
  File "ext/_yaml.pyx", line 905, in _yaml.CParser._parse_next_event
yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 11, column 1
could not find expected ':'
  in "<unicode string>", line 12, column 1
make: *** [modules] Error 1

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name dict_diff
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name dict_diff

The test ansible-test sanity --test import --python 2.7 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name dict_diff
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name dict_diff
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name dict_diff

The test ansible-test sanity --test import --python 3.5 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff'
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name 'dict_diff'
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff'
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name 'dict_diff'
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)

The test ansible-test sanity --test import --python 3.8 [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)
lib/ansible/modules/network/ios/ios_lldp_global.py:213:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)
test/runner/.tox/import/lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py:20:0: ImportError: cannot import name 'dict_diff' from 'ansible.module_utils.network.ios.utils.utils' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/network/ios/utils/utils.py)

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/facts/lldp_global/lldp_global.py:87:9: E303 too many blank lines (3)

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_facts.py:0:0: E326 Argument 'gather_network_resources' in argument_spec defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces'], ['l2_interfaces'], ['!l2_interfaces'], ['vlans'], ['!vlans'], ['lag_interfaces'], ['!lag_interfaces'], ['lacp'], ['!lacp'], ['lacp_interfaces'], ['!lacp_interfaces'], ['lldp_global'], ['!lldp_global']]) but documentation defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces'], ['l2_interfaces'], ['!l2_interfaces'], ['vlans'], ['!vlans'], ['lag_interfaces'], ['!lag_interfaces'], ['lacp'], ['!lacp'], ['lacp_interfaces'], ['!lacp_interfaces']])
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'cannot import name 'dict_diff''
lib/ansible/modules/network/ios/ios_lldp_global.py:48:1: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_lldp_global.py:48:1: error DOCUMENTATION: syntax error: could not find expected ':'

click here for bot help

@ansible-zuul
Copy link

ansible-zuul bot commented Aug 21, 2019

Build succeeded (third-party-check pipeline).

@justjais justjais marked this pull request as ready for review August 21, 2019 09:09
@justjais justjais changed the title [WIP] Resource module for ios_lldp_global Resource module for ios_lldp_global Aug 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/network/ios/ios_facts.py:0:0: E326 Argument 'gather_network_resources' in argument_spec defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces'], ['l2_interfaces'], ['!l2_interfaces'], ['vlans'], ['!vlans'], ['lag_interfaces'], ['!lag_interfaces'], ['lacp'], ['!lacp'], ['lacp_interfaces'], ['!lacp_interfaces'], ['lldp_global'], ['!lldp_global']]) but documentation defines choices as ([['all'], ['!all'], ['interfaces'], ['!interfaces'], ['l2_interfaces'], ['!l2_interfaces'], ['vlans'], ['!vlans'], ['lag_interfaces'], ['!lag_interfaces'], ['lacp'], ['!lacp'], ['lacp_interfaces'], ['!lacp_interfaces']])
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E322 Argument 'port_vlan:' found in config -> tlv_select is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E323 Argument '4_wire_power_management' found in config -> tlv_select is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E323 Argument 'port_vlan' found in config -> tlv_select is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E336 Argument 'port_vlan:' in argument_spec found in config -> tlv_select is not a valid python identifier
lib/ansible/modules/network/ios/ios_lldp_global.py:0:0: E337 Argument 'port_vlan:' in argument_spec found in config -> tlv_select defines type as 'bool' but documentation doesn't define type

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. test This PR relates to tests. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_triage Needs a first human triage before being processed. labels Aug 21, 2019
@justjais justjais requested a review from ganeshrn August 21, 2019 09:54
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

cc @privateip
click here for bot help

danielmellado
danielmellado suggested changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@danielmellado danielmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, some minor changes needed. Thanks!

lib/ansible/module_utils/network/ios/config/lldp_global/lldp_global.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/ios/ios_lldp_global.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/ios/ios_lldp_global.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/ios/ios_lldp_global.py Outdated Show resolved Hide resolved
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

cc @privateip
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 21, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Aug 21, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

@justjais this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Aug 21, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 21, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Aug 21, 2019

Build succeeded (third-party-check pipeline).

@justjais justjais merged commit 35d457a into ansible:devel Aug 21, 2019
@justjais justjais added this to Module Completed in Ansible 2.9 Networking Feature Dev Aug 21, 2019
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@justjais @adharshsrivatsr
Resource module for ios_lldp_global (ansible#60506)
97f9b2a 
* ios_lldp_global model

* final fix for lldp_global

* fix shippable n reviews

* fix reviews
@ansible ansible locked and limited conversation to collaborators Sep 18, 2019
@justjais justjais deleted the ios_lldp branch October 18, 2019 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@danielmellado danielmellado Awaiting requested review from danielmellado

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
Ansible 2.9 Networking Feature Dev
  
Module Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjais @ansibot @danielmellado @ganeshrn