Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documented disadvantages of using default zabbix password for all zab… #60639

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Documented disadvantages of using default zabbix password for all zab… #60639

merged 2 commits into from
Aug 16, 2019

Conversation

D3DeFi
Copy link
Contributor

@D3DeFi D3DeFi commented Aug 15, 2019

SUMMARY

Using default password zabbix will make some content to be hidden in module output. This happens due to no_log=True option being enabled on module argument login_password.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/plugins/doc_fragments/zabbix.py

ADDITIONAL INFORMATION

Issue described in #39220

fatal: [zbx-dev-node001]: FAILED! => changed=false
  msg: 'Missing required ********-api module (check docs or install with: pip install ********-api)'

@D3DeFi D3DeFi mentioned this pull request Aug 15, 2019
Merged
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Aug 15, 2019
@acozine
Copy link
Contributor

acozine commented Aug 15, 2019

Thanks @D3DeFi for the PR.

For anyone who finds this PR when searching for information about how no_log affects Ansible output, we document the problem on the Network FAQ page: https://docs.ansible.com/ansible/devel/network/user_guide/faq.html#why-is-my-output-sometimes-replaced-with.

@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Aug 15, 2019
@D3DeFi
Copy link
Contributor Author

D3DeFi commented Aug 15, 2019

Oh my, this mobile version... will fix this asap from PC

@D3DeFi
Copy link
Contributor Author

D3DeFi commented Aug 15, 2019

Thanks for suggestions @acozine . Should be ok now

@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/plugins/doc_fragments/zabbix.py:53:161: E501 line too long (193 > 160 characters)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 15, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 15, 2019
gundalow
gundalow previously requested changes Aug 16, 2019
View reviewed changes
lib/ansible/plugins/doc_fragments/zabbix.py Outdated
@@ -48,4 +48,7 @@ class ModuleDocFragment(object):
type: bool
default: yes
version_added: "2.5"
notes:
- If you use I(login_password=zabbix), the word "zabbix" is replaced by "********" in all module output, because I(login_password) uses C(no_log).
See L(this FAQ,https://docs.ansible.com/ansible/devel/network/user_guide/faq.html#why-is-my-output-sometimes-replaced-with) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See L(this FAQ,https://docs.ansible.com/ansible/devel/network/user_guide/faq.html#why-is-my-output-sometimes-replaced-with) for more information.
See L(this FAQ,https://docs.ansible.com/ansible/latest/network/user_guide/faq.html#why-is-my-output-sometimes-replaced-with) for more information.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 16, 2019
@D3DeFi @acozine
Update lib/ansible/plugins/doc_fragments/zabbix.py
fb88e34 
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
@D3DeFi
Copy link
Contributor Author

D3DeFi commented Aug 16, 2019

ready_for_review

@acozine acozine dismissed gundalow’s stale review August 16, 2019 15:57

Jinx - @gundalow and I requested the same change, which has been addressed.

@acozine acozine merged commit df9b4fa into ansible:devel Aug 16, 2019
@ansible ansible locked and limited conversation to collaborators Sep 13, 2019
@D3DeFi D3DeFi deleted the zabbix-doc-nolog branch October 21, 2019 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

@gundalow gundalow gundalow left review comments

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@D3DeFi @acozine @ansibot @gundalow