-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FortiOS modules for 2.9 - 3 #60678
FortiOS modules for 2.9 - 3 #60678
Conversation
@mamunozgonzalez this PR contains the following merge commits: Please rebase your branch to remove these commits. |
@mamunozgonzalez this PR contains the following merge commits: Please rebase your branch to remove these commits. |
f33dd12
to
4ef5f87
Compare
4ef5f87
to
0aafbd4
Compare
choices: | ||
- enable | ||
- disable | ||
no-next: | ||
no_next: | ||
description: | ||
- Enable/disable blocking packets with the No Next header (default = disable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc description mentions "default = disable", then it should also be present in argspec and in doc too as default: disable
.
description: | ||
- Enable/disable blocking packets with the No Next header (default = disable) | ||
type: str | ||
choices: | ||
- enable | ||
- disable | ||
routing: | ||
description: | ||
- Enable/disable blocking packets with Routing headers (default = enable). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In certain modules, some parameters have a default mentioned in its description. If those are valid, then the default key should added in argspec and doc too.
choices: | ||
- enable | ||
- disable | ||
bindtofw: | ||
description: | ||
- Enable/disable use of IP/MAC binding to filter packets that would normally go to the firewall. | ||
type: str | ||
choices: | ||
- enable | ||
- disable | ||
undefinedhost: | ||
description: | ||
- Select action to take on packets with IP/MAC addresses not in the binding list (default = block). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Present here.
- Indicates whether to create or remove the object | ||
choices: | ||
- present | ||
- absent | ||
action: | ||
description: | ||
- Action performed on traffic matching the policy (default = deny). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Present here.
SUMMARY
This PR contains an update to fortios modules that includes all of the changes requested for 2.9.
ISSUE TYPE
COMPONENT NAME
fortios_firewall_internet_service_group
fortios_firewall_ipmacbinding_setting
fortios_firewall_ipmacbinding_table
fortios_firewall_ippool6
fortios_firewall_ippool
fortios_firewall_ip_translation
fortios_firewall_ipv6_eh_filter
fortios_firewall_ldb_monitor
fortios_firewall_local_in_policy6
fortios_firewall_local_in_policy
fortios_firewall_multicast_address6
fortios_firewall_multicast_address
fortios_firewall_multicast_policy6
fortios_firewall_multicast_policy
fortios_firewall_policy46
fortios_firewall_policy64
fortios_firewall_policy6
fortios_firewall_policy
fortios_firewall_profile_group
fortios_firewall_profile_protocol_options