Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FortiOS modules for 2.9 - 3 #60678

Merged

Conversation

migumun
Copy link
Contributor

@migumun migumun commented Aug 16, 2019

SUMMARY

This PR contains an update to fortios modules that includes all of the changes requested for 2.9.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

fortios_firewall_internet_service_group
fortios_firewall_ipmacbinding_setting
fortios_firewall_ipmacbinding_table
fortios_firewall_ippool6
fortios_firewall_ippool
fortios_firewall_ip_translation
fortios_firewall_ipv6_eh_filter
fortios_firewall_ldb_monitor
fortios_firewall_local_in_policy6
fortios_firewall_local_in_policy
fortios_firewall_multicast_address6
fortios_firewall_multicast_address
fortios_firewall_multicast_policy6
fortios_firewall_multicast_policy
fortios_firewall_policy46
fortios_firewall_policy64
fortios_firewall_policy6
fortios_firewall_policy
fortios_firewall_profile_group
fortios_firewall_profile_protocol_options

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. fortios Fortios community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 16, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2019

@mamunozgonzalez this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 16, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2019

@mamunozgonzalez this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 16, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 16, 2019
choices:
- enable
- disable
no-next:
no_next:
description:
- Enable/disable blocking packets with the No Next header (default = disable)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc description mentions "default = disable", then it should also be present in argspec and in doc too as default: disable.

description:
- Enable/disable blocking packets with the No Next header (default = disable)
type: str
choices:
- enable
- disable
routing:
description:
- Enable/disable blocking packets with Routing headers (default = enable).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor

@NilashishC NilashishC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In certain modules, some parameters have a default mentioned in its description. If those are valid, then the default key should added in argspec and doc too.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 19, 2019
choices:
- enable
- disable
bindtofw:
description:
- Enable/disable use of IP/MAC binding to filter packets that would normally go to the firewall.
type: str
choices:
- enable
- disable
undefinedhost:
description:
- Select action to take on packets with IP/MAC addresses not in the binding list (default = block).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Present here.

- Indicates whether to create or remove the object
choices:
- present
- absent
action:
description:
- Action performed on traffic matching the policy (default = deny).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Present here.

@NilashishC NilashishC merged commit decb016 into ansible:devel Aug 19, 2019
@ansible ansible locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. fortios Fortios community module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants