Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate net_* modules #60818

Merged
merged 4 commits into from
Aug 26, 2019
Merged

Deprecate net_* modules #60818

merged 4 commits into from
Aug 26, 2019

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Aug 19, 2019 •
edited

SUMMARY

Closes #60010

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

All core-supported network agnostic modules except net_get and net_put

@Qalthos Qalthos requested a review from ganeshrn August 19, 2019 14:52
@ansibot
Copy link
Contributor

ansibot commented Aug 19, 2019

cc @NilashishC @danielmellado @ganeshrn @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. system System category community_review In order to be merged, this PR must follow the community review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Aug 19, 2019
gundalow
gundalow reviewed Aug 23, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add changelog & porting guide entry, thanks

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 23, 2019

cc @acozine
click here for bot help

@ansibot ansibot added docs This issue/PR relates to or includes documentation. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels Aug 23, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 23, 2019
@Qalthos Qalthos merged commit f3f30c1 into ansible:devel Aug 26, 2019
@Qalthos Qalthos deleted the deprecate_net branch August 26, 2019 13:07
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@Qalthos @adharshsrivatsr
Deprecate net_* modules (ansible#60818)
69e9f2e 
* Deprecate net_ modules

* Move modules to finish deprecation

* Add missing `why`, move net_static_route

* Add changelogs and porting guide
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@Qalthos @anas-shami
Deprecate net_* modules (ansible#60818)
ea22365 
* Deprecate net_ modules

* Move modules to finish deprecation

* Add missing `why`, move net_static_route

* Add changelogs and porting guide
@ansible ansible locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. deprecated This issue/PR relates to a deprecated module. docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add deprecation notice to these network modules - Net Modules
3 participants
@Qalthos @ansibot @gundalow