Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename hcloud_*_facts to hcloud_*_info #60926

Merged
merged 11 commits into from Aug 21, 2019
Merged

Rename hcloud_*_facts to hcloud_*_info #60926

merged 11 commits into from Aug 21, 2019

Conversation

LKaemmerling
Copy link
Contributor

@LKaemmerling LKaemmerling commented Aug 20, 2019 •
edited

SUMMARY

This will rename all hcloud_*_facts modules to *_info.

Closes #60516

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • hcloud_datacenter_facts
  • hcloud_floating_ip_facts
  • hcloud_image_facts
  • hcloud_location_facts
  • hcloud_server_facts
  • hcloud_server_type_facts
  • hcloud_ssh_key_facts
  • hcloud_volume_facts
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

cc @cschmitt-hcloud
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud community_review In order to be merged, this PR must follow the community review workflow. deprecated This issue/PR relates to a deprecated module. hcloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:1:0: missing-final-newline Final newline missing
lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:1:0: undefined-variable Undefined variable 'hcloud_datacenter_info'

The test ansible-test sanity --test ansible-doc [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/modules/list_of_cloud_modules.rst:726:0: undefined-label: undefined label: hcloud_datacenter_facts_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:1:0: NameError: name 'hcloud_datacenter_info' is not defined

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:1:0: NameError: name 'hcloud_datacenter_info' is not defined

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:1:0: NameError: name 'hcloud_datacenter_info' is not defined

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:1:0: NameError: name 'hcloud_datacenter_info' is not defined

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:1:0: NameError: name 'hcloud_datacenter_info' is not defined

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:1:0: NameError: name 'hcloud_datacenter_info' is not defined

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:0:0: missing: __metaclass__ = type

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/_hcloud_datacenter_facts.py:1:26: W292 no newline at end of file

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

cc @cschmitt-hcloud
click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_datacenter_info.py:55:17: W291 trailing whitespace

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/hcloud/hcloud_datacenter_info.py:55:17: W291 trailing whitespace

click here for bot help

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

@cschmitt-hcloud @LKaemmerling

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

@cschmitt-hcloud @LKaemmerling

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

@LKaemmerling this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

cc @mattclay
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 20, 2019

@LKaemmerling this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Aug 20, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 21, 2019
ghost
ghost approved these changes Aug 21, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felixfontein
felixfontein reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've found one minor detail; if you want to change it, please do so.

What's missing are porting guide entries and a changelog. See 2d98734 for how this should look like.

lib/ansible/modules/cloud/hcloud/hcloud_datacenter_info.py
hcloud_datacenter_info:
description:
- The datacenter info as list
- This module was called C(hcloud_datacenter_facts) before Ansible 2.9, returning C(ansible_facts) and C(hcloud_datacenter_facts).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- This module was called C(hcloud_datacenter_facts) before Ansible 2.9, returning C(ansible_facts) and C(hcloud_datacenter_facts).
- This module was called C(hcloud_datacenter_facts) before Ansible 2.9, returning C(hcloud_datacenter_facts) as C(ansible_facts).

You have to decide whether you want to change this in all places (or in none :) ).

@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

@LKaemmerling This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed deprecated This issue/PR relates to a deprecated module. labels Aug 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

@LKaemmerling this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

@LKaemmerling This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added the merge_commit This PR contains at least one merge commit. Please resolve! label Aug 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

@LKaemmerling this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot removed the merge_commit This PR contains at least one merge commit. Please resolve! label Aug 21, 2019
@LKaemmerling LKaemmerling reopened this Aug 21, 2019
@felixfontein felixfontein merged commit 96199be into ansible:devel Aug 21, 2019
@felixfontein
Copy link
Contributor

@LKaemmerling @cschmitt-hcloud thanks for working on this!

@LKaemmerling LKaemmerling deleted the rename_hcloud_facts_to_hcloud_info branch August 21, 2019 13:04
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@LKaemmerling @adharshsrivatsr
Rename hcloud_*_facts to hcloud_*_info (ansible#60926)
9876605 
* Rename hcloud_datacenter_facts to hcloud_datacenter_info

* Rename hcloud_location_facts to hcloud_location_info

* Rename hcloud_image_facts to hcloud_image_info

* Rename hcloud_floating_ip_facts to hcloud_floating_ip_info

* Rename hcloud_server_type_facts to hcloud_server_type_info

* Rename hcloud_server_facts to hcloud_server_info

* Rename hcloud_ssh_key_facts to hcloud_ssh_key_info

* Rename hcloud_volume_facts to hcloud_volume_info

* Fix typo in hcloud_image_info

* Add to porting guide and add changelog fragment

* Reword porting guide
@ansible ansible locked and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud hcloud module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hetzner Cloud _facts modules need to be renamed to _info and stop returning ansible_facts
4 participants
@LKaemmerling @ansibot @felixfontein @sivel