Make sure droplet deletion works even when idempotency is achieved using 'name' and 'unique_name' rather than 'id' #6104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this fixes a bug that makes it impossible to delete a droplet that is specified with just a combination of name and unique_names (for idempotency).
In particular, without the fix, this code:
will always fail with:
because the module will fail, not finding 'id' (even though, according to the manual and to what I need to do, seems like a completely legit case)