Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIGIP: multiple_fixes_2 #61071

Merged
merged 1 commit into from Aug 22, 2019
Merged

BIGIP: multiple_fixes_2 #61071

merged 1 commit into from Aug 22, 2019

Conversation

wojtek0806
Copy link
Contributor

SUMMARY

fixed multiple issues with integration tests
added RD support for source parameter
fixed a problem with name parameter in bigip_user module
removed deprecated parameters

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/f5/bigip_user.py
lib/ansible/modules/network/f5/bigip_virtual_server.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

cc @caphrim007
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. committer_review In order to be merged, this PR must follow the certified review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:certified This issue/PR relates to certified code. labels Aug 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Aug 21, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/network/f5/bigip_virtual_server.py:1829:18: blacklisted-name Black listed name "_"
lib/ansible/modules/network/f5/bigip_virtual_server.py:1849:18: blacklisted-name Black listed name "_"

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Aug 21, 2019
@wojtek0806
removed deprecated parameters
977a87a 
fixed multiple issues with integration tests
added RD support for source parameter
fixed a problem with name parameter in bigip_user module
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 21, 2019
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Aug 22, 2019
@caphrim007
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Aug 22, 2019
@caphrim007 caphrim007 merged commit 8bfa756 into ansible:devel Aug 22, 2019
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@wojtek0806 @adharshsrivatsr
removed deprecated parameters (ansible#61071)
7fbb914 
fixed multiple issues with integration tests
added RD support for source parameter
fixed a problem with name parameter in bigip_user module
@ansible ansible locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. f5 module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wojtek0806 @ansibot @caphrim007