Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module aliases back in hardcoded module_defaults list #61203

Merged
merged 1 commit into from Aug 26, 2019
Merged

Add module aliases back in hardcoded module_defaults list #61203

merged 1 commit into from Aug 26, 2019

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Aug 23, 2019 •
edited

SUMMARY

module_defaults should keep working for previous module names

Fixes #61068

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/config/module_defaults.yml

@s-hertel s-hertel mentioned this pull request Aug 23, 2019
Merged
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 23, 2019
@felixfontein
Copy link
Contributor

Thanks for fixing this! I wasn't aware that it doesn't work for aliases...

@felixfontein
Copy link
Contributor

For OpenStack, there's at least one new module for 2.9 (os_group_info) which isn't in the module_defaults list.

@s-hertel
Copy link
Contributor Author

@felixfontein Yeah, it was a surprise to me too, sorry for not catching it during the initial pull requests. I think I'm going to let re-syncing the list for new modules (like os_group_info) be a follow-up PR. I just replaced anything that was removed from module_defaults since it could break playbooks that were previously working.

@s-hertel s-hertel mentioned this pull request Aug 23, 2019
Closed
felixfontein
felixfontein approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a diff with the same file of stable-2.8, compared to stable-2.8 there are now only new entries and no removed ones.

shipit

@ansibot ansibot added has_issue shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 23, 2019
@s-hertel s-hertel merged commit 1d405fd into ansible:devel Aug 26, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 26, 2019
adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
@s-hertel @adharshsrivatsr
Add module aliases back in hardcoded module_defaults list (ansible#61203
ea3c31d 
)
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@s-hertel @anas-shami
Add module aliases back in hardcoded module_defaults list (ansible#61203
4bf46c0 
)
@ansible ansible locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. has_issue shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module_defaults don't apply to aliased modules
4 participants
@s-hertel @felixfontein @sivel @ansibot