Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxd_container: enables to set keys not present in existing config #61607

Merged
merged 1 commit into from
Sep 19, 2019
Merged

lxd_container: enables to set keys not present in existing config #61607

merged 1 commit into from
Sep 19, 2019

Conversation

satunnainen
Copy link
Contributor

SUMMARY

Changes enable to set new keys which don't exist in a current container's configuration. Currently explicit setting previously unset keys are leads to fail with KeyError.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lxd_container

@ansibot
Copy link
Contributor

ansibot commented Aug 30, 2019

cc @hnakamur
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Aug 30, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 30, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 30, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 17, 2019
@gundalow gundalow changed the title enables to set keys not present in existing config lxd_container: enables to set keys not present in existing config Sep 19, 2019
@gundalow gundalow added the pr_day Has been reviewed during a PR review Day label Sep 19, 2019
@gundalow
Copy link
Contributor

rebuild_merge
Once merged could please create a backport PR including changelog/fragment file https://docs.ansible.com/ansible/latest/community/development_process.html#making-your-pr-merge-worthy

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 19, 2019
@ansibot ansibot merged commit 9552503 into ansible:devel Sep 19, 2019
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@satunnainen @anas-shami
enables to set keys not present in existing config (ansible#61607)
d2cf4e0
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. pr_day Has been reviewed during a PR review Day shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@satunnainen @ansibot @gundalow