Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display leftover messages when shutting down. #62431

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Display leftover messages when shutting down. #62431

merged 1 commit into from
Sep 19, 2019

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Sep 17, 2019

SUMMARY

Some messages get quashed when the persistent connection process is shut down. This will log them to the ansible log file if ANSIBLE_PERSISTENT_LOG_MESSAGES is set.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-connection

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 17, 2019
@danielmellado danielmellado removed the needs_triage Needs a first human triage before being processed. label Sep 19, 2019
@Qalthos Qalthos merged commit 9a43a8f into ansible:devel Sep 19, 2019
@Qalthos Qalthos deleted the unstrand_messages branch September 19, 2019 14:37
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@Qalthos @anas-shami
Display leftover messages when shutting down. (ansible#62431)
104915c
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Qalthos @ganeshrn @danielmellado @ansibot