-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for backup option dest key for network modules #62444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-powis
changed the title
dest lives in 4 different places depending on exeuction type
dest lives in 4 different places depending on execution type
Sep 17, 2019
ansibot
added
affects_2.10
This issue/PR affects Ansible v2.10
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
networking
Network category
new_contributor
This PR is the first contribution by a new community member.
small_patch
support:network
This issue/PR relates to code supported by the Ansible Network Team.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Sep 17, 2019
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
Oct 1, 2019
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Oct 8, 2019
justjais
removed
the
needs_triage
Needs a first human triage before being processed.
label
Oct 9, 2019
ganeshrn
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
ganeshrn
changed the title
dest lives in 4 different places depending on execution type
Fix for backup option dest key for network modules
Oct 9, 2019
nitzmahone
pushed a commit
that referenced
this pull request
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.10
This issue/PR affects Ansible v2.10
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
networking
Network category
new_contributor
This PR is the first contribution by a new community member.
small_patch
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
support:network
This issue/PR relates to code supported by the Ansible Network Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #57131
'dest' lives as a function level variable as defined at https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/action/network.py#L76
and in the nested dictionary in 3 different places under 2 different situations:
Under normal running (and with --diff):
When running with --check
And always:
This change cleans up the code a little, while using the function level variable we already had set.
ISSUE TYPE
COMPONENT NAME
action plugin, network.py