Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for backup option dest key for network modules #62444

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

james-powis
Copy link
Contributor

SUMMARY

Fixes #57131

'dest' lives as a function level variable as defined at https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/action/network.py#L76

and in the nested dictionary in 3 different places under 2 different situations:

Under normal running (and with --diff):

if 'dest' in copy_result:
    result['backup_path'] = copy_result['dest']

When running with --check

if 'invocation' in copy_result and 'dest' in copy_result['invocation']:
    result['backup_path'] = copy_result['invocation']['dest']

And always:

result['backup_path'] = copy_result['invocation']['module_args']['dest']

This change cleans up the code a little, while using the function level variable we already had set.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

action plugin, network.py

@james-powis james-powis changed the title dest lives in 4 different places depending on exeuction type dest lives in 4 different places depending on execution type Sep 17, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 17, 2019

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 17, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 1, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 8, 2019
@justjais justjais requested a review from ganeshrn October 9, 2019 14:08
@justjais justjais removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2019
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ganeshrn ganeshrn merged commit d4ad541 into ansible:devel Oct 9, 2019
ganeshrn pushed a commit to ganeshrn/ansible that referenced this pull request Oct 9, 2019
@ganeshrn ganeshrn changed the title dest lives in 4 different places depending on execution type Fix for backup option dest key for network modules Oct 9, 2019
ganeshrn pushed a commit to ganeshrn/ansible that referenced this pull request Oct 9, 2019
nitzmahone pushed a commit that referenced this pull request Nov 12, 2019
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with KeyError on nxos_config module
4 participants