Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find - clarify description of 'contains' #62445

Merged
merged 1 commit into from Sep 26, 2019
Merged

find - clarify description of 'contains' #62445

merged 1 commit into from Sep 26, 2019

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Sep 17, 2019 •
edited

SUMMARY

Fixes #61983

The contains parameter is meant to be a single regular expression based on its use in the module code.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/files/find.py

@ansibot
Copy link
Contributor

ansibot commented Sep 17, 2019

cc @bcoca
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. files Files category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 17, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 17, 2019
@samdoran samdoran force-pushed the issue/61983-find-contians-docs branch from 97e03a7 to dd474e2 Compare September 18, 2019 20:23
@samccann samccann merged commit 2375fd0 into ansible:devel Sep 26, 2019
@samdoran samdoran deleted the issue/61983-find-contians-docs branch September 27, 2019 15:45
samdoran added a commit to samdoran/ansible that referenced this pull request Sep 27, 2019
@samdoran
[stable-2.9] find - clarify description of 'contains' (ansible#62445)
1ed6331 
(cherry picked from commit 2375fd0)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@samdoran samdoran mentioned this pull request Sep 27, 2019
Merged
acozine pushed a commit that referenced this pull request Sep 30, 2019
@samdoran @acozine
[stable-2.9] find - clarify description of 'contains' (#62445) (#62917)
56054be 
(cherry picked from commit 2375fd0)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansible ansible locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca left review comments

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. files Files category module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

find_module: contains attribute ambiguously described
4 participants
@samdoran @ansibot @bcoca @samccann