luks_device: ansibot wasn't able to extract author #62464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansibullbot ignores lines without 'author' or dash [1].
The following command allows to check that no other module is impacted:
rgrep -A1 -P "^author:[[:space:]]*$" lib/ansible/modules/ |grep -P "\.py-[[:space:]]*[^-][[:space:]A-Za-z\"'@()]+$" -B1
Related: ansible/ansibullbot#1106.
[1] https://github.com/ansible/ansibullbot/blob/02ae638641c0ac9d6331b768592eeaac446fa80d/ansibullbot/utils/moduletools.py#L828
ansibot
added
affects_2.10
felixfontein
approved these changes
Sep 18, 2019
ansibot
added
automerge
|
I think there's no need to backport this since the author is showing fine in the generated docs (https://docs.ansible.com/ansible/latest/modules/luks_device_module.html#authors). |
anas-shami
pushed a commit
to anas-shami/ansible
that referenced
this pull request
Sep 23, 2019
Ansibullbot ignores lines without 'author' or dash [1].
The following command allows to check that no other module is impacted:
rgrep -A1 -P "^author:[[:space:]]*$" lib/ansible/modules/ |grep -P "\.py-[[:space:]]*[^-][[:space:]A-Za-z\"'@()]+$" -B1
Related: ansible/ansibullbot#1106.
[1] https://github.com/ansible/ansibullbot/blob/02ae638641c0ac9d6331b768592eeaac446fa80d/ansibullbot/utils/moduletools.py#L828
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Ansibullbot ignores lines without
authoror dashThe following command allows to check that no other module is impacted:
It would be better to improve Ansibullbot in order to handle this formatting but an update recently ignored it (ansible/ansibullbot#1106), hence this proposal.
ISSUE TYPE
COMPONENT NAME
luks_device