Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disabled for hcloud_floating_ip_info tests #62494

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Remove disabled for hcloud_floating_ip_info tests #62494

merged 1 commit into from
Sep 18, 2019

Conversation

LKaemmerling
Copy link
Contributor

SUMMARY

Follow up from #62409 (review)
closes: #62414

ISSUE TYPE
COMPONENT NAME

hcloud_floating_ip_info

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

cc @cschmitt-hcloud
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 cloud community_review In order to be merged, this PR must follow the community review workflow. hcloud needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 18, 2019
@LKaemmerling
Copy link
Contributor Author

@goneri @mattclay

resmo
resmo approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@resmo resmo merged commit d5449ee into ansible:devel Sep 18, 2019
@LKaemmerling LKaemmerling deleted the reenable-hcloud_floating_ip_info_tests branch September 18, 2019 12:28
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Sep 18, 2019
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@LKaemmerling @anas-shami
tests: hcloud: Enable hcloud_floating_ip_info tests (ansible#62494)
ce70abd
@ansible ansible locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cloud community_review In order to be merged, this PR must follow the community review workflow. hcloud support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hcloud_floating_ip_info: test fails (two floating IPs, one expected)
4 participants
@LKaemmerling @ansibot @resmo @sivel