Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS-XR: Fail with a better message when config is not provided #62515

Merged
merged 1 commit into from
Oct 3, 2019
Merged

IOS-XR: Fail with a better message when config is not provided #62515

merged 1 commit into from
Oct 3, 2019

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented Sep 18, 2019 •
edited

Depends-On: #62998
Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
  • No more traceback on empty config when state is 'merged', 'replaced' or 'overridden'.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iosxr_interfaces.py
iosxr_l2_interfaces.py
iosxr_l3_interfaces.py
iosxr_lacp.py
iosxr_lag_interfaces.py
iosxr_lacp_interfaces.py
iosxr_lldp_global.py
iosxr_lldp_interfaces.py

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

cc @Qalthos @danielmellado @ganeshrn @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community iosxr Cisco IOSXR community needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 18, 2019
@NilashishC NilashishC force-pushed the fix_traceback_for_rm branch 2 times, most recently from 192e68f to dbc3a1a Compare September 18, 2019 15:08
@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

cc @NilashishC
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 18, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Sep 18, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 18, 2019

Build succeeded (third-party-check pipeline).

@NilashishC
Fix traceback for empty config
cc606f2 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 18, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 18, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 18, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 19, 2019
@NilashishC
Copy link
Contributor Author

recheck

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 30, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 30, 2019

Build succeeded (third-party-check pipeline).

@NilashishC
Copy link
Contributor Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Oct 1, 2019

Build succeeded (third-party-check pipeline).

@NilashishC NilashishC merged commit fc5358c into ansible:devel Oct 3, 2019
NilashishC added a commit to NilashishC/ansible that referenced this pull request Oct 3, 2019
@NilashishC
Fix traceback for empty config (ansible#62515)
2c19052 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit fc5358c)

Add changelog for IOS-XR traceback fix

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC mentioned this pull request Oct 3, 2019
Merged
NilashishC added a commit to NilashishC/ansible that referenced this pull request Oct 3, 2019
@NilashishC
Fix traceback for empty config (ansible#62515)
d9a070b 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit fc5358c)

Add changelog for IOS-XR traceback fix

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

Remove empty spaces
nitzmahone pushed a commit that referenced this pull request Nov 12, 2019
@NilashishC @nitzmahone
Fix traceback for empty config (#62515) (#63089)
5558b43 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit fc5358c)

Add changelog for IOS-XR traceback fix

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

Remove empty spaces
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justjais justjais justjais approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community iosxr Cisco IOSXR community networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NilashishC @ansibot @justjais