Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vyosnoconfig tracebackfix #62518

Merged
merged 3 commits into from
Sep 18, 2019
Merged

vyosnoconfig tracebackfix #62518

merged 3 commits into from
Sep 18, 2019

Conversation

rohitthakur2590
Copy link
Contributor

Signed-off-by: rohitthakur2590 rohitthakur2590@outlook.com

SUMMARY

vyos traceback fix when config in none

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • vyos_lldp_interfaces
  • vyos_lldp_global
    -vyos_lag_interfaces
ADDITIONAL INFORMATION
before 
  File 

fatal: [192.168.56.101]: FAILED! => {
    "changed": false, 
ule_utils/network/vyos/config/lag_interfaces/lag_interfaces.py\", line 64, in execute_module\n  File \"/tmp/ansible_vyos_lag_interfaces_payload_xOAAjj/ansible_vyos_lag_interfaces_payload.zip/ansible/module_utils/network/vyos/config/lag_interfaces/lag_interfaces.py\", line 96, in set_config\n  File \"/tmp/ansible_vyos_lag_interfaces_payload_xOAAjj/ansible_vyos_lag_interfaces_payload.zip/ansible/module_utils/network/vyos/config/lag_interfaces/lag_interfaces.py\", line 122, in set_state\nTypeError: 'NoneType' object is not iterable\n", 
    "module_stdout": "", 
    "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", 
    "rc": 1
}

after
fatal: [192.168.56.101]: FAILED! => {
    "changed": false, 
    "invocation": {
        "module_args": {
            "config": null, 
            "state": "merged"
        }
    }, 
    "msg": "config is required for state merged"
}

@rohitthakur2590
vyosnoconfig tracebackfix
1ce76a3 
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 18, 2019
@rohitthakur2590
vyos noconfig tracebackfix test cases added
ce6a69e 
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 18, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 18, 2019

Build succeeded (third-party-check pipeline).

@rohitthakur2590 rohitthakur2590 merged commit b24f7d2 into ansible:devel Sep 18, 2019
rohitthakur2590 added a commit to rohitthakur2590/ansible that referenced this pull request Sep 19, 2019
@rohitthakur2590
vyosnoconfig tracebackfix (ansible#62518)
f646189 
* vyosnoconfig tracebackfix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos noconfig tracebackfix test cases added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test/integration/targets/vyos_lldp_global/tests/cli/empty_config.yaml

(cherry picked from commit b24f7d2)
abadger pushed a commit that referenced this pull request Sep 19, 2019
@rohitthakur2590 @abadger
[Backport 2.9] vyos: Fix to give no traceback on empty config (#62568)
d58d2bc 
* vyosnoconfig tracebackfix (#62518)

* vyosnoconfig tracebackfix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos noconfig tracebackfix test cases added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test/integration/targets/vyos_lldp_global/tests/cli/empty_config.yaml

(cherry picked from commit b24f7d2)

* empty config traceback fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@rohitthakur2590 @anas-shami
vyosnoconfig tracebackfix (ansible#62518)
3c32cf9 
* vyosnoconfig tracebackfix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos noconfig tracebackfix test cases added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test/integration/targets/vyos_lldp_global/tests/cli/empty_config.yaml
@ansible ansible locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NilashishC NilashishC NilashishC approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rohitthakur2590 @ansibot @NilashishC