Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VyOS: Fix tracebacks with empty config #62520

Merged
merged 1 commit into from
Sep 30, 2019
Merged

VyOS: Fix tracebacks with empty config #62520

merged 1 commit into from
Sep 30, 2019

Conversation

NilashishC
Copy link
Contributor

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
  • No more traceback on empty config when state is 'merged', 'replaced' or 'overridden'.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vyos_interfaces.py
vyos_l3_interfaces.py

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

cc @Qalthos @danielmellado @ganeshrn @justjais @NilashishC @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 18, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 18, 2019

Build succeeded (third-party-check pipeline).

@NilashishC
Fix traceback for empty config
430ae86 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 18, 2019

Build succeeded (third-party-check pipeline).

@danielmellado danielmellado removed the needs_triage Needs a first human triage before being processed. label Sep 19, 2019
@NilashishC NilashishC merged commit 67213cc into ansible:devel Sep 30, 2019
NilashishC added a commit to NilashishC/ansible that referenced this pull request Oct 3, 2019
@NilashishC
Fix traceback for empty config (ansible#62520)
8756623 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit 67213cc)

Add changelog for vyos traceback fix
@ansible ansible locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NilashishC @ansibot @danielmellado