Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error message updated #62536

Merged
merged 3 commits into from
Sep 19, 2019
Merged

error message updated #62536

merged 3 commits into from
Sep 19, 2019

Conversation

rohitthakur2590
Copy link
Contributor

@rohitthakur2590 rohitthakur2590 commented Sep 18, 2019 •
edited

Signed-off-by: rohitthakur2590 rohitthakur2590@outlook.com

SUMMARY

No traceback on empty config when state is 'merged', 'replaced' or 'overridden'.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • vyos_lldp_interfaces
  • vyos_lldp_global
  • vyos_lsg_interfaces
ADDITIONAL INFORMATION

@rohitthakur2590
error message updated
ab39000 
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 18, 2019
@rohitthakur2590
test cases updated
2a14774 
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
@rohitthakur2590
error message updated
4ef30c0 
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 18, 2019

Build succeeded (third-party-check pipeline).

@rohitthakur2590 rohitthakur2590 merged commit 978def3 into ansible:devel Sep 19, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Sep 19, 2019
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@rohitthakur2590 @anas-shami
error message updated (ansible#62536)
8132245 
* error message updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* error message updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NilashishC NilashishC Awaiting requested review from NilashishC

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rohitthakur2590 @ansibot @sivel