Master #62626
Merged
Master #62626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Test-Path to use -LiteralPath instead of -Path to fix issue where powershell will not detect path with special characters such as '=' and '[]'.
modified other instances of -Path and changed to -LiteralPath. All except line L243 since it is a different function.
ansibot
added
affects_2.10
jborean93
approved these changes
Sep 20, 2019
|
Thanks for working on this one. |
|
If you would like to see this in Ansible 2.9, you can follow https://docs.ansible.com/ansible/latest/community/development_process.html#backporting-merged-prs to create a backport PR. Please make sure you create a changelog fragment as well if you wish to backport this. |
This was referenced Sep 20, 2019
sivel
removed
the
needs_triage
anas-shami
pushed a commit
to anas-shami/ansible
that referenced
this pull request
Sep 23, 2019
* Update win_package.ps1 Update Test-Path to use -LiteralPath instead of -Path to fix issue where powershell will not detect path with special characters such as '=' and '[]'. * Update win_package.ps1 modified other instances of -Path and changed to -LiteralPath. All except line L243 since it is a different function. * added literal path to get-itemproperty
richardsonky
added a commit
to richardsonky/ansible
that referenced
this pull request
Sep 23, 2019
* Update win_package.ps1 Update Test-Path to use -LiteralPath instead of -Path to fix issue where powershell will not detect path with special characters such as '=' and '[]'. * Update win_package.ps1 modified other instances of -Path and changed to -LiteralPath. All except line L243 since it is a different function. * added literal path to get-itemproperty (cherry picked from commit 153a322)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Test-Path to use -LiteralPath instead of -Path to fix issue where powershell will not detect path with special characters such as '=' and '[]'.
SUMMARY
Fix for #62521
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
win_package
ADDITIONAL INFORMATION
If the path variable is contains characters such as '=' or '[]' powershell can't verify the path using Test-Path. The powershell command needs to be Test-Path -LiteralPath for it verify it correctly.