cloudflare_dns: Rename account_api_token parameter #62707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Name change triggered by the new parameter _api_token_ (8cabf1c) being a bit too similar to the old name _account_api_token_. At the same time _account_api_key_ is actually a better name for the original parameter, in it mapping closer to the terminology used by Cloudflare. Keeping _account_api_token_ as an alias for backward compatibility.
anas-shami
pushed a commit
to anas-shami/ansible
that referenced
this pull request
Sep 23, 2019
Name change triggered by the new parameter _api_token_ (8cabf1c) being a bit too similar to the old name _account_api_token_. At the same time _account_api_key_ is actually a better name for the original parameter, in it mapping closer to the terminology used by Cloudflare. Keeping _account_api_token_ as an alias for backward compatibility.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Name change triggered by the new parameter api_token (8cabf1c) being
a bit too similar to the old name account_api_token. At the same
time account_api_key is actually a better name for the original
parameter, in it mapping closer to the terminology used by Cloudflare.
Keeping account_api_token as an alias for backward compatibility.
ISSUE TYPE
COMPONENT NAME
cloudflare_dns