Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.9/62587 module_utils/network/cloudengine:fix get_nc_next. #62752

Merged
merged 3 commits into from Oct 12, 2019
Merged

Backport/2.9/62587 module_utils/network/cloudengine:fix get_nc_next. #62752

merged 3 commits into from Oct 12, 2019

Conversation

yuandongx
Copy link
Contributor

@yuandongx yuandongx commented Sep 23, 2019 •
edited

SUMMARY

The NETCONF client can interact with the device using the action,when the query returns more than 30K.The 'set-id' may change over the time althougth 'set-id' is the indentify of next rpc packet and also RPC xml attribute. So fix it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/network/cloudengine/ce.py
lib/ansible/plugins/netconf/ce.py
changelogs/fragments/60569-plugins-netconf-ce.yml
changelogs/fragments/62587-module_utils-network-cloudengine.yml

ADDITIONAL INFORMATION
The PR has been validated many times on real devices befor it was ready for review.

RPC requset

<rpc message-id="103" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
  <get-next xmlns="http://www.huawei.com/netconf/capability/base/1.0" set-id="989"> 
  </get-next>
</rpc>

RPC reply

<?xml version="1.0" encoding="UTF-8"?>
<rpc-reply message-id="103" xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" set-id="989">
  <data>
    <ifm xmlns="http://www.huawei.com/netconf/vrp" format-version="1.0" content-version="1.0">
      <interfaces>
        <interface>
          <ifIndex>3</ifIndex>
          <ifName>Virtual-Template1</ifName>
          <ifPhyType>Virtual-Template</ifPhyType>
     <!-- additional <user> elements appear here... --> 
        </interface>
      </interfaces>
    </ifm>
  </data>
</rpc-reply>

set-id changed in next reply

@yuandongx
fix plugins/netconf/ce.py for netconf/capability/exchange (#60569)
b0497bc 
(cherry picked from commit 037401b)
@yuandongx
for capability/exchange/1.0 (#60630)
add070e 
* for capability/exchange/1.0

* for capability/exchange/1.0

* update for shippable

* Update ce.py

* Update ce.py

(cherry picked from commit 28227c9)
@yuandongx
module_utils-network-cloudengine： fix get_nc_next. (#62587)
ee310cd 
* fix get_nc_next.

* add a changelog fragment.

* upadte for  changelgo fragment.

* merge two prs, one depens another.

* merge two prs, one depens another.

* update changelog.

(cherry picked from commit d6ef7c8)
@ansibot
Copy link
Contributor

ansibot commented Sep 23, 2019

cc @NilashishC @Qalthos @QijunPan @TommyLike @danielmellado @edisonxiang @freesky-edward @ganeshrn @hwDCN @justjais @niuzhenguo @trishnaguha @zengchen1024 @zhongjun2
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Sep 23, 2019
@yuandongx yuandongx marked this pull request as ready for review September 23, 2019 14:56
@ansible-zuul
Copy link

ansible-zuul bot commented Sep 23, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 1, 2019
@yuandongx yuandongx closed this Oct 8, 2019
@yuandongx yuandongx reopened this Oct 8, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 8, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 8, 2019

Build succeeded (third-party-check pipeline).

@abadger abadger changed the base branch from stable-2.9 to temporary-2.9.1-branch-releng-only October 12, 2019 15:48
@abadger abadger merged commit 73ec34a into ansible:temporary-2.9.1-branch-releng-only Oct 12, 2019
@abadger
Copy link
Contributor

abadger commented Oct 12, 2019

Merged to the temporary-2.9.1-branch-releng-only branch for the 2.9.1 release.

@yuandongx yuandongx deleted the backport/2.9/62587 branch October 12, 2019 16:01
abadger pushed a commit that referenced this pull request Oct 12, 2019
@yuandongx @abadger
Backport/2.9/62587 module_utils/network/cloudengine:fix get_nc_next. (#…
8c05339 
…62752)

* fix plugins/netconf/ce.py for netconf/capability/exchange (#60569)


(cherry picked from commit 037401b)

* for capability/exchange/1.0 (#60630)

* for capability/exchange/1.0

* for capability/exchange/1.0

* update for shippable

* Update ce.py

* Update ce.py

(cherry picked from commit 28227c9)

* module_utils-network-cloudengine： fix get_nc_next. (#62587)

* fix get_nc_next.

* add a changelog fragment.

* upadte for  changelgo fragment.

* merge two prs, one depens another.

* merge two prs, one depens another.

* update changelog.

(cherry picked from commit d6ef7c8)
@yuandongx yuandongx mentioned this pull request Oct 12, 2019
Merged
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 14, 2019
abadger pushed a commit that referenced this pull request Nov 1, 2019
@yuandongx @abadger
Backport/2.9/62587 module_utils/network/cloudengine:fix get_nc_next. (#…
9d1f07d 
…62752)

* fix plugins/netconf/ce.py for netconf/capability/exchange (#60569)


(cherry picked from commit 037401b)

* for capability/exchange/1.0 (#60630)

* for capability/exchange/1.0

* for capability/exchange/1.0

* update for shippable

* Update ce.py

* Update ce.py

(cherry picked from commit 28227c9)

* module_utils-network-cloudengine： fix get_nc_next. (#62587)

* fix get_nc_next.

* add a changelog fragment.

* upadte for  changelgo fragment.

* merge two prs, one depens another.

* merge two prs, one depens another.

* update changelog.

(cherry picked from commit d6ef7c8)
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuandongx @ansibot @abadger @sivel