Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix obvious typos #62821

Merged
merged 33 commits into from Oct 18, 2019
Merged

Fix obvious typos #62821

merged 33 commits into from Oct 18, 2019

Conversation

z3dm4n
Copy link
Contributor

@z3dm4n z3dm4n commented Sep 25, 2019

SUMMARY
  • fix obvious typos in quite a lot of files

@z3dm4n
lib/ansible/modules/cloud/digital_ocean/digital_ocean_snapshot_info.p…
1cb3c13 
…y: fix typos
@z3dm4n
lib/ansible/modules/cloud/ovirt/ovirt_host_network.py: fix typos
9d833df
@z3dm4n
test/integration/targets/cnos_backup/README.md: fix typos
e17bbad
@z3dm4n
test/integration/targets/cnos_bgp/README.md: fix typos
d2f7cae
@z3dm4n
test/integration/targets/cnos_command/README.md: fix typos
d2cd7b7
@z3dm4n
test/integration/targets/cnos_conditional_command/README.md: fix typos
2186862
@z3dm4n
test/integration/targets/cnos_conditional_template/README.md: fix typos
90af432
@z3dm4n
test/integration/targets/cnos_config/README.md: fix typos
71cc321
@z3dm4n
test/integration/targets/cnos_facts/README.md: fix typos
f1da58a
@z3dm4n
test/integration/targets/cnos_image/README.md: fix typos
e874c6f
@z3dm4n
test/integration/targets/cnos_rollback/README.md: fix typos
f9235d8
@z3dm4n
test/integration/targets/cnos_save/README.md: fix typos
6dd47c3
@z3dm4n
test/integration/targets/cnos_showrun/README.md: fix typos
c23d8e8
@z3dm4n
test/integration/targets/cnos_template/README.md: fix typos
64e21e2
@z3dm4n
test/integration/targets/cnos_vlag/README.md: fix typos
7afa570
@z3dm4n
test/integration/targets/enos_command/README.md: fix typos
bfb5059
@z3dm4n
test/integration/targets/enos_config/README.md: fix typos
77d9183
@z3dm4n
test/integration/targets/enos_facts/README.md: fix typos
d2dd02d
@z3dm4n
test/legacy/roles/cnos_backup/README.md: fix typos
fb7ddc9
@z3dm4n
test/legacy/roles/cnos_bgp/README.md: fix typos
9a7d8f7
@z3dm4n
test/legacy/roles/cnos_command/README.md: fix typos
769504b
@z3dm4n
test/legacy/roles/cnos_conditional_command/README.md: fix typos
d5ceaa3
@z3dm4n
test/legacy/roles/cnos_conditional_template/README.md: fix typos
2612e0a
@z3dm4n
test/legacy/roles/cnos_ethernet/README.md: fix typos
469fc5a
@z3dm4n
test/legacy/roles/cnos_facts/README.md: fix typos
598d598
@z3dm4n
test/legacy/roles/cnos_image/README.md: fix typos
a9f61bd
@z3dm4n
test/legacy/roles/cnos_portchannel/README.md: fix typos
e0317a9
@z3dm4n
test/legacy/roles/cnos_rollback/README.md: fix typos
535e4ea
@z3dm4n
test/legacy/roles/cnos_save/README.md: fix typos
417889d
@z3dm4n
test/legacy/roles/cnos_showrun/README.md: fix typos
7fd3af6
@ansibot
Copy link
Contributor

ansibot commented Sep 25, 2019

cc @Akasurde @BondAnthony @amuraleedhar @dkasberg @machacekondra @mattclay @mgregson @mnecas @mwperina
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 cloud core_review In order to be merged, this PR must follow the core review workflow. digital_ocean module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. ovirt oVirt and RHV community small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 25, 2019
mwperina
mwperina approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ovirt related changes looks good, thanks

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 25, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 3, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 11, 2019
gundalow
gundalow approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work thank you. This does really help improve the documentation.

Just an FYI, this is as large as we'd want a PR to get. The larger they are, the higher the chance of merge conflicts.

@gundalow gundalow merged commit 5ea7293 into ansible:devel Oct 18, 2019
@gundalow gundalow added this to To do in OLD Ansible Documentation via automation Oct 18, 2019
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 cloud core_review In order to be merged, this PR must follow the core review workflow. digital_ocean module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. ovirt oVirt and RHV community small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@z3dm4n @ansibot @gundalow @mwperina