Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facts: detect FreeBSD jails guest #62857

Merged
merged 2 commits into from Sep 26, 2019
Merged

facts: detect FreeBSD jails guest #62857

merged 2 commits into from Sep 26, 2019

Conversation

leManu
Copy link
Contributor

@leManu leManu commented Sep 26, 2019

SUMMARY

Fixes #36350

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/facts/virtual/freebsd.py
lib/ansible/module_utils/facts/virtual/sysctl.py

ADDITIONAL INFORMATION

Before:

$ ansible -m setup -a 'filter=ansible_virtualization_*' freebsd
192.168.122.133 | SUCCESS => {
    "ansible_facts": {
        "ansible_virtualization_role": "", 
        "ansible_virtualization_type": ""
    }, 
    "changed": false
}

After:

$ ansible -m setup -a 'filter=ansible_virtualization_*' freebsd
192.168.122.133 | SUCCESS => {
   "ansible_facts": {
       "ansible_virtualization_role": "guest", 
       "ansible_virtualization_type": "jails"
   }, 
   "changed": false
}

@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2019

cc @JoergFiedler @MacLemon @bcoca @dagwieers @dch @jasperla @mekanix @opoplawski @overhacked @tuxillo
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bsd BSD community bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/facts/virtual/freebsd.py:44:161: E501: line too long (173 > 160 characters)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 26, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed small_patch needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 26, 2019
@bcoca bcoca merged commit f8fcf7f into ansible:devel Sep 26, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 26, 2019
abadger pushed a commit that referenced this pull request Oct 14, 2019
@dgeo @abadger
[backport 2.9] facts: detect FreeBSD jails guest (#62857) (#62913)
37bf2b4 
* facts: detect FreeBSD jails guest (#62857)

* facts: detect FreeBSD jails

* PEP8 fix

* changelog for pr62913
abadger pushed a commit that referenced this pull request Oct 14, 2019
@dgeo @abadger
[backport 2.8] facts: detect FreeBSD jails guest (#62857) (#62911)
33af575 
* facts: detect FreeBSD jails guest (#62857)

* facts: detect FreeBSD jails

* PEP8 fix

* changelog for pr62913
@ansible ansible locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bsd BSD community bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide virtualization_role and virtualization_type for FreeBSD jails
3 participants
@leManu @ansibot @bcoca