Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow option docker_storage_driver=overlay2 in module os_coe_cluster_template #62874

Merged
merged 1 commit into from
Sep 26, 2019
Merged

allow option docker_storage_driver=overlay2 in module os_coe_cluster_template #62874

merged 1 commit into from
Sep 26, 2019

Conversation

pescobar
Copy link
Contributor

SUMMARY

Allow to define docker_storage_driver=overlay2 in module os_coe_cluster_template

Currently only devicemapper and overlay are supported

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_coe_cluster_template

ADDITIONAL INFORMATION

Openstack magnum already supports overlay2 and it's the recommended driver by docker

The overlay2 driver is supported on Docker Engine - Community, and Docker EE 17.06.02-ee5 and up, and is the recommended storage driver.

https://docs.docker.com/storage/storagedriver/overlayfs-driver/

jovial
jovial approved these changes Sep 26, 2019
View reviewed changes
Copy link

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot
Copy link
Contributor

ansibot commented Sep 26, 2019

cc @Shrews @cloudnull @dagnello @emonty @flwang @gtema @juliakreger @mnaser @odyssey4me @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. openstack small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Sep 26, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Sep 26, 2019

Build succeeded (third-party-check pipeline).

@mnaser
Copy link
Contributor

mnaser commented Sep 26, 2019

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Sep 26, 2019
gtema
gtema approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 26, 2019
@ansibot ansibot merged commit de51552 into ansible:devel Sep 26, 2019
@ansible ansible locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jovial jovial jovial approved these changes

@brtkwr brtkwr brtkwr approved these changes

@gtema gtema gtema approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. openstack shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pescobar @ansibot @mnaser @jovial @brtkwr @gtema