Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_replication: add basic CI tests for MariaDB from scratch #62907

Merged
merged 1 commit into from
Sep 27, 2019
Merged

mysql_replication: add basic CI tests for MariaDB from scratch #62907

merged 1 commit into from
Sep 27, 2019

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Sep 27, 2019 •
edited

SUMMARY

mysql_replication: add basic CI tests for MariaDB from scratch

It needs to complete related PR, for example, #62648

This tests are basic now.
All mysql_replication's features will be covered later.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mysql_replication

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 27, 2019
@Andersson007 Andersson007 force-pushed the mariadb_replication_ci branch 2 times, most recently from 2a94d2a to e8f73d6 Compare September 27, 2019 12:12
@Andersson007 Andersson007 reopened this Sep 27, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 27, 2019
@Andersson007 Andersson007 mentioned this pull request Sep 27, 2019
Merged
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 27, 2019
@Andersson007
Copy link
Contributor Author

ready_for_review

gundalow
gundalow reviewed Sep 27, 2019
View reviewed changes
test/integration/targets/mariadb_replication/tasks/mariadb_replication_initial.yml
@@ -0,0 +1,72 @@
# Copyright: (c) 2019, Andrew Klychkov (@Andersson007) <aaklychkov@mail.ru>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is mariadb_replication tested already by this target?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, i made it from scratch (there aren't any ci for mysql_replication now)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added checks for 3 basic options

test/integration/targets/setup_mariadb/tasks/setup_mariadb.yml
- name: Pause
pause: seconds=3

########### For painful debug uncomment the lines below ##
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and will save people time in the future, thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was suffering for 3 days trying to launch 2 MariaDB instances in one container and configure replication between them :) so decided to left these lines :)

bmalynovytch
bmalynovytch approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@bmalynovytch bmalynovytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👏

@bmalynovytch
Copy link
Contributor

shipit

@Andersson007
Copy link
Contributor Author

Andersson007 commented Sep 27, 2019 •
edited

@bmalynovytch thanks for reviewing and approving!
after that, i hope, we will cope with mysql_replication related PRs (i'll try to rewrite them if their authors don't)

@gundalow gundalow merged commit 334d2ce into ansible:devel Sep 27, 2019
@Andersson007
Copy link
Contributor Author

@gundalow , thank you for reviewing and merging!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 1, 2019
@ansible ansible locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

@bmalynovytch bmalynovytch bmalynovytch approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Andersson007 @bmalynovytch @gundalow @sivel @ansibot