FortiAnalyzer Network Manager Hotfix #62919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
|
ready_for_review |
ansibot
added
the
stale_ci
justjais
removed
the
needs_triage
Qalthos
suggested changes
Oct 23, 2019
ansibot
added
needs_revision
ftntcorecse
force-pushed
the
faz_netmgr_hotfix
branch
from
fd49d1a
to
a92cd99
Compare
ansibot
removed
the
stale_ci
ftntcorecse
commented
Nov 21, 2019
ansibot
added
stale_ci
|
@Qalthos -- Please come back to this. We need to get it merged. We have multiple issues and reports that are waiting on this hotfix and people are starting to manually install it from this PR. We need this merged as soon as possible. Please let me know how I can help you approve this, if anything else needs to happen. |
Qalthos
suggested changes
Feb 5, 2020
ansibot
removed
stale_review
ftntcorecse
force-pushed
the
faz_netmgr_hotfix
branch
from
ff564ae
to
203f7a0
Compare
Qalthos
suggested changes
Feb 7, 2020
Qalthos
suggested changes
Feb 7, 2020
…ues introduced in Ansible 2.9.
…ues introduced in Ansible 2.9.
Co-Authored-By: Nathaniel Case <this.is@nathanielca.se>
Co-Authored-By: Nathaniel Case <this.is@nathanielca.se>
ftntcorecse
force-pushed
the
faz_netmgr_hotfix
branch
from
b556e4c
to
b7df9dc
Compare
Qalthos
suggested changes
Feb 11, 2020
|
My apologies, you're absolutely right. This was added in 2.9. We wrote them at the same time but it just took this long to get it. Change is coming... |
…own as "2.9". Also, need to kick shippable off again.
Qalthos
approved these changes
Feb 12, 2020
|
Thanks. Ship it. |
ansibot
added
core_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Hotfix for connection manager persistent connection initialization.
The issue is that the login() function is no longer being automatically called when playbooks start. So our module_utils would assume that connection had been made and try to send data and fail. We've added some code to the send_request() portion to double check if the network manager is connected, and if it isn't, we run the _connect() function from the connection object.
ISSUE TYPE
COMPONENT NAME
plugins/httpapi/fortianalyzer.py
ADDITIONAL INFORMATION