Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ostype win10 support for proxmox_kvm to resolve issue #55045 #62987

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

jlreiter
Copy link
Contributor

@jlreiter jlreiter commented Oct 1, 2019

SUMMARY

Added 'win10' to the list of hardcoded supported values for the variable: ostype.
Qemu officially supports this as a value as denoted here: https://pve.proxmox.com/wiki/Qemu/KVM_Virtual_Machines

Fixes #55045

#55045: proxmox_kvm cannot create a VM with ostype=win10
This patch is not currently present in any version of the proxmox_kvm module up through stable 2.9.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_kvm

ADDITIONAL INFORMATION

Before

TASK [create/deploy vms] ***********************************************************************************************
failed: [proxmox] (item={'value': {u'ostype': u'win10', u'type': u'windows1903', u'ide': {'ide0': 'pd4_1T/iso:Windows10_1903.iso,media=cdrom'}, u'vmid': 997, u'name': u'win1903'}, 'key': u'windows'}) => {"ansible_loop_var": "item", "changed": false, "item": {"key": "windows", "value": {"ide": {"ide0": "pd4_1T/iso:Windows10_1903.iso,media=cdrom"}, "name": "win1903", "ostype": "win10", "type": "windows1903", "vmid": 997}}, "msg": "value of ostype must be one of: other, wxp, w2k, w2k3, w2k8, wvista, win7, win8, l24, l26, solaris, got: win10"}

After

TASK [create/deploy vms] ***********************************************************************************************
changed: [pvecenter710.breakfasthouse.xyz] => (item={'value': {u'ostype': u'win10', u'type': u'windows1903', u'ide': {'ide0': 'pd4_1T:iso/Windows10_1903.iso,media=cdrom'}, u'vmid': 997, u'name': u'win1903'}, 'key': u'windows'})

@ansibot
Copy link
Contributor

ansibot commented Oct 1, 2019

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Oct 1, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 9, 2019
@gundalow gundalow merged commit 0b97180 into ansible:devel Oct 18, 2019
@gundalow
Copy link
Contributor

Merged into devel for release in Ansible 2.10, thanks.

If you'd like to see this fixed in Ansible 2.9.1 please raise a backport PR including a changelog/fragment/ file, see https://docs.ansible.com/ansible/latest/community/development_process.html#making-your-pr-merge-worthy

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 22, 2019
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxmox_kvm cannot create a VM with ostype=win10
4 participants