[stable-2.9] rpmfilename must be constructed using rpmmacros #63025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different subpackages have different names so, at the least, the %NAME macros must be used when constructing the rpmfilename. Otherwise each subsequent subpackage will overwrite the previous one. This reinstates dag's fix from d4b6aec Fixes ansible#62673 (cherry picked from commit 30cc54d) Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
ansibot
added
affects_2.9
ansibot
added
the
stale_ci
mattclay
added
the
backport_verified
sivel
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different subpackages have different names so, at the least, the %NAME
macros must be used when constructing the rpmfilename. Otherwise each
subsequent subpackage will overwrite the previous one.
This reinstates dag's fix from d4b6aec
Fixes #62673
(cherry picked from commit 30cc54d)
Backport of #63023
Co-authored-by: Toshio Kuratomi a.badger@gmail.com
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
This fix shouldn't affect the ansible release. We use the
mock-rpmtarget to make releases. We can therefore hold off on merging the backport until after 2.9.0 is out.