Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_replication: add return value, remove extra argument from function #63036

Merged
merged 1 commit into from
Oct 2, 2019
Merged

mysql_replication: add return value, remove extra argument from function #63036

merged 1 commit into from
Oct 2, 2019

Conversation

Andersson007
Copy link
Contributor

SUMMARY

mysql_replication: add return value, remove extra argument from function

  • it gives us and users useful information about what has actually been done on hosts
  • it useful for CI tests and debug (used widely in postgresql modules, i added this feature earlier to them - really useful)
  • it gives us opportunity to check even non supported features by checking executed queries (for example, there are a lot of forks including percone, mariadb, etc., so we could tests parameters supported in one and non supported in another rdbms)
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mysql_replication

@ansibot
Copy link
Contributor

ansibot commented Oct 2, 2019

cc @Alexander198961 @Xyon @banyek @bmalynovytch @bmildren @kurtdavis @michaelcoburn @Oneiroi @tolland
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. database Database category feature This issue/PR relates to a feature request. module This issue/PR relates to a module. mysql needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 2, 2019
@Andersson007 Andersson007 force-pushed the mysql_replication_add_return_value branch 2 times, most recently from 26f78b8 to c5e9503 Compare October 2, 2019 08:51
@Andersson007 Andersson007 force-pushed the mysql_replication_add_return_value branch from c5e9503 to a9bb531 Compare October 2, 2019 09:40
@felixfontein felixfontein merged commit 0706782 into ansible:devel Oct 2, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 8, 2019
@ansible ansible locked and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. database Database category feature This issue/PR relates to a feature request. module This issue/PR relates to a module. mysql support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andersson007 @ansibot @felixfontein @sivel