Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix junos unicode errors. #63046

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Fix junos unicode errors. #63046

merged 1 commit into from
Oct 9, 2019

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Oct 2, 2019

SUMMARY

Fixes #62983

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_facts

@Qalthos Qalthos requested a review from ganeshrn October 2, 2019 13:14
@Qalthos Qalthos mentioned this pull request Oct 2, 2019
Closed
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Oct 2, 2019
pabelanger
pabelanger approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@pabelanger pabelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why we didn't catch it in our testing? Or how we can improve it for the future? If we want to get this into 2.9.0, I think we may also want to add changelog entry and some sort of test.

@ansible-zuul
Copy link

ansible-zuul bot commented Oct 2, 2019

Build succeeded (third-party-check pipeline).

@mtucker502
Copy link

I did test this same process on Debian instead of MacOS and it worked fine. So it's specific to Python3 on MacOS from my testing.

@justjais justjais merged commit d336a14 into ansible:devel Oct 9, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2019
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
@Qalthos Qalthos deleted the junos_str_fix branch August 19, 2022 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pabelanger pabelanger pabelanger approved these changes

@justjais justjais justjais approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

junos_facts in 2.9rc1 throws exception. Works in 2.8
6 participants
@Qalthos @mtucker502 @pabelanger @justjais @sivel @ansibot