-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql_replication: add basic CI tests with MySQL 5.6 #63124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job again @Andersson007 !
LGTM but maybe should you add a test that checks, after the replication is started, that what you did on master is also done on the slave (ie: creating a table in the previously added db)
@bmalynovytch , thank you for reviewing and the suggestion! |
@bmalynovytch i added the suggested checks :) please look. |
I thought you'd add a SELECT to check the inserted values 🙂 LGTM |
Btw, I'm wondering if we shouldn't add a little timer before checking replication occurred properly, as the test could be run before replication actually happens, as it is async, or add a small retry loop, to be sure people don't get false negative tests, just because of load on the test / CI env. |
yep, just in case, added |
Thank you, guys, for reviewing and merging! |
SUMMARY
mysql_replication: add basic CI tests with MySQL 5.6, master-standby configuration in one container
it's needed for testing hanged PRs, e.g. #56767
ISSUE TYPE
COMPONENT NAME
mysql_replication