Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mariadb_replication / mysql_replication integration tests: conflicts on centos7 #63171

Merged

Conversation

felixfontein
Copy link
Contributor

SUMMARY

When both the mariadb_replication and mysql_replication tests are run, they fail on CentOS 7 (see here). This moves the mariadb_replication test to POSIX group 2 (the mysql_replication test runs in group 4) to avoid this problem.

Thanks to @Andersson007 for suggesting this.

CC @mattclay

ISSUE TYPE
  • Bugfix Pull Request
  • Test Pull Request
COMPONENT NAME

mariadb_replication
mysql_replication

@felixfontein felixfontein changed the title mariadb_replication / mysql_replication: conflicts on centos7 mariadb_replication / mysql_replication integration tests: conflicts on centos7 Oct 6, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 6, 2019

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. database Database category mysql needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Oct 6, 2019
@Andersson007
Copy link
Contributor

Good job, thank you! Will know,
shipit

@felixfontein felixfontein merged commit a99af71 into ansible:devel Oct 6, 2019
@felixfontein felixfontein deleted the mariadb-mysql-replication-tests branch October 6, 2019 08:21
@felixfontein
Copy link
Contributor Author

@Andersson007 thanks for helping to fix this :)

@mattclay
Copy link
Member

mattclay commented Oct 7, 2019

What is the underlying issue with the tests? Using groups to avoid conflicts between tests is a good temporary solution, but not something we should rely on long-term.

@Andersson007
Copy link
Contributor

@mattclay , I recently added CI tests for mysql_replication module to solve all abandoned prs.
As we know, mysql has a lot of forks including MariaDB which has some additional features related to replication.
Therefore, we need both, MySQL and MariaDB.
If we install one of them to a container, it will pull libraries and then we can’t install the other because of conflicts between dependencies.
So it’s not a problem of tests themselves.
I think it is ok to install services to separate containers to avoid conflicts of dependencies.
If it is critical to have both in one container, of course, i could spend (valuable) time trying to clean them up but better I would fix a couple of old abandoned PRs instead :)

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 8, 2019
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. database Database category mysql support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants