mysql_info: add support for global status #63189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
bmalynovytch
approved these changes
Oct 7, 2019
ansibot
removed
the
needs_triage
|
Thank you! I’ll try to look at this tomorrow morning |
Andersson007
suggested changes
Oct 8, 2019
There was a problem hiding this comment.
@sayap , good job! thank you for the PR!
I tried it manually - works as expected.
IMO global_status looks better that just status, more obvious and it corresponds to the SQL.
Would you mind to change it, please ?
| @@ -25,8 +25,8 @@ | |||
| filter: | |||
| description: | |||
| - Limit the collected information by comma separated string or YAML list. | |||
| - Allowable values are C(version), C(databases), C(settings), C(users), | |||
| C(slave_status), C(slave_hosts), C(master_status), C(engines). | |||
| - Allowable values are C(version), C(databases), C(settings), C(status), | |||
There was a problem hiding this comment.
Suggested change
| - Allowable values are C(version), C(databases), C(settings), C(status), | |
| - Allowable values are C(version), C(databases), C(settings), C(global_status), |
There was a problem hiding this comment.
Agree, I have renamed it to global_status
ansibot
added
needs_revision
Signed-off-by: Yap Sok Ann <sokann@gmail.com>
sayap
force-pushed
the
mysql-info-global-status
branch
from
3804b62
to
ae9948d
Compare
ansibot
added
community_review
|
shipit |
ansibot
added
shipit
|
thanks all! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This allows the mysql_info module to also include the output of
SHOW GLOBAL STATUS.ISSUE TYPE
COMPONENT NAME
mysql_info
ADDITIONAL INFORMATION
For my specific use case, we are checking whether the global status
wsrep_local_state_commentis equal toSynced, after adding a node to galera replication.