Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Add module defaults for VMware modules #63197

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Oct 7, 2019

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

changelogs/fragments/vmware-module_fragments-group.yml
docs/docsite/rst/user_guide/playbooks_module_defaults.rst
lib/ansible/config/module_defaults.yml

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde requested review from goneri and jillr October 7, 2019 12:20
@ansibot
Copy link
Contributor

ansibot commented Oct 7, 2019

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 7, 2019
@goneri
Copy link
Contributor

goneri commented Oct 7, 2019

Awsome, thanks @dmsimard for the idea ;-).

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 7, 2019
@Akasurde
Copy link
Member Author

Akasurde commented Oct 7, 2019

Awsome, thanks @dmsimard for the idea ;-).

Yes, @dmsimard gave this idea while we were watching keynote in AnsibleFest 2019.

@goneri goneri merged commit deda9d4 into ansible:devel Oct 7, 2019
goneri added a commit to goneri/ansible that referenced this pull request Oct 7, 2019
Use `module_defaults` to reduce the amount of duplicated parameters.

See: ansible#63197
goneri added a commit to goneri/ansible that referenced this pull request Oct 7, 2019
Use `module_defaults` to reduce the amount of duplicated parameters.

As a bonus point, we won't have to set `validate_certs: no` in the test-suite
roles.

See: ansible#63197
goneri added a commit to goneri/ansible that referenced this pull request Oct 7, 2019
Use `module_defaults` to reduce the amount of duplicated parameters.

As a bonus point, we won't have to set `validate_certs: no` in the test-suite
roles.

See: ansible#63197
goneri added a commit to goneri/ansible that referenced this pull request Oct 7, 2019
Use `module_defaults` to reduce the amount of duplicated parameters.

As a bonus point, we won't have to set `validate_certs: no` in the test-suite
roles.

See: ansible#63197
@dmsimard
Copy link
Contributor

dmsimard commented Oct 7, 2019

👍

goneri added a commit to goneri/ansible that referenced this pull request Oct 7, 2019
Use `module_defaults` to reduce the amount of duplicated parameters.

As a bonus point, we won't have to set `validate_certs: no` in the test-suite
roles.

See: ansible#63197
goneri added a commit to goneri/ansible that referenced this pull request Oct 7, 2019
Use `module_defaults` to reduce the amount of duplicated parameters.

As a bonus point, we won't have to set `validate_certs: no` in the test-suite
roles.

See: ansible#63197
@Akasurde Akasurde deleted the vmware_module_defaults branch October 8, 2019 01:49
goneri added a commit to goneri/ansible that referenced this pull request Oct 8, 2019
Use `module_defaults` to reduce the amount of duplicated parameters.

As a bonus point, we won't have to set `validate_certs: no` in the test-suite
roles.

See: ansible#63197
goneri added a commit to goneri/ansible that referenced this pull request Oct 8, 2019
Use `module_defaults` to reduce the amount of duplicated parameters.

As a bonus point, we won't have to set `validate_certs: no` in the test-suite
roles.

See: ansible#63197
goneri added a commit to goneri/ansible that referenced this pull request Oct 8, 2019
Use `module_defaults` to reduce the amount of duplicated parameters.

As a bonus point, we won't have to set `validate_certs: no` in the test-suite
roles.

See: ansible#63197
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants