Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Unit tests to eos_logging #63248

Merged
merged 9 commits into from Nov 5, 2019
Merged

Added Unit tests to eos_logging #63248

merged 9 commits into from Nov 5, 2019

Conversation

GomathiselviS
Copy link
Contributor

SUMMARY

Added Unit Testcases to eos_logging module

ISSUE TYPE

  • Feature Pull Request
COMPONENT NAME

test/units/modules/network/eos/test_eos_logging.py

@ansibot
Copy link
Contributor

ansibot commented Oct 8, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Oct 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 8, 2019

The test ansible-test sanity --test pylint [explain] failed with 5 errors:

test/units/modules/network/eos/test_eos_logging.py:67:38: bad-whitespace: Exactly one space required after comma         self.assertEqual(result['msg'],"size must be between 10 and 2147483647")                                       ^
test/units/modules/network/eos/test_eos_logging.py:68:0: trailing-whitespace: Trailing whitespace
test/units/modules/network/eos/test_eos_logging.py:73:38: bad-whitespace: Exactly one space required after comma         self.assertEqual(result['msg'],"argument size is of type <class 'str'> and we were unable to convert to int: <class 'str'> cannot be converted to an int")                                       ^
test/units/modules/network/eos/test_eos_logging.py:84:0: trailing-whitespace: Trailing whitespace
test/units/modules/network/eos/test_eos_logging.py:90:68: trailing-whitespace: Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 6 errors:

test/units/modules/network/eos/test_eos_logging.py:67:39: E231: missing whitespace after ','
test/units/modules/network/eos/test_eos_logging.py:68:1: W293: blank line contains whitespace
test/units/modules/network/eos/test_eos_logging.py:73:39: E231: missing whitespace after ','
test/units/modules/network/eos/test_eos_logging.py:73:161: E501: line too long (162 > 160 characters)
test/units/modules/network/eos/test_eos_logging.py:84:1: W293: blank line contains whitespace
test/units/modules/network/eos/test_eos_logging.py:90:69: W291: trailing whitespace

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 8, 2019
@GomathiselviS GomathiselviS added support:network This issue/PR relates to code supported by the Ansible Network Team. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 8, 2019
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed support:network This issue/PR relates to code supported by the Ansible Network Team. labels Oct 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 8, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/network/eos/test_eos_logging.py:73:161: E501: line too long (177 > 160 characters)

click here for bot help

@goneri goneri added the ci_verified Changes made in this PR are causing tests to fail. label Oct 9, 2019
@ansibot ansibot removed needs_triage Needs a first human triage before being processed. ci_verified Changes made in this PR are causing tests to fail. labels Oct 9, 2019
@GomathiselviS
Copy link
Contributor Author

recheck

@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/modules/network/eos/test_eos_logging.py:73:56: bad-whitespace: Exactly one space required after comma         self.assertIn("we were unable to convert to int",result['msg'])                                                         ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/units/modules/network/eos/test_eos_logging.py:73:57: E231: missing whitespace after ','

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Oct 9, 2019
@GomathiselviS GomathiselviS added needs_triage Needs a first human triage before being processed. support:network This issue/PR relates to code supported by the Ansible Network Team. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 9, 2019
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Oct 9, 2019
@GomathiselviS GomathiselviS removed the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Oct 9, 2019
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Oct 9, 2019
@GomathiselviS GomathiselviS added the support:network This issue/PR relates to code supported by the Ansible Network Team. label Oct 16, 2019
@ansibot ansibot removed the support:network This issue/PR relates to code supported by the Ansible Network Team. label Oct 16, 2019
Qalthos
Qalthos suggested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again with commands that aren't asserted. You could probably at least do something with load_config.assert_called_once_with(...) if you really wanted to, but that's probably overkill

test/units/modules/network/eos/test_eos_logging.py Outdated Show resolved Hide resolved
test/units/modules/network/eos/test_eos_logging.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 25, 2019

@GomathiselviS this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 25, 2019
@GomathiselviS
Copy link
Contributor Author

recheck

@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 25, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 4, 2019
@GomathiselviS GomathiselviS merged commit 143b5a3 into ansible:devel Nov 5, 2019
@ansible ansible locked and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@trishnaguha trishnaguha Awaiting requested review from trishnaguha

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GomathiselviS @ansibot @Qalthos @goneri