Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STS assume role error message when role does not exist #63249

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

jillr
Copy link
Contributor

@jillr jillr commented Oct 8, 2019

SUMMARY

AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sts_assume_role

ADDITIONAL INFORMATION

We last changed this assertion in #46026 for the same reason.

@jillr jillr requested a review from s-hertel October 8, 2019 19:46
@ansibot
Copy link
Contributor

ansibot commented Oct 8, 2019

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 8, 2019
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2019
@jillr jillr merged commit ce402f0 into ansible:devel Oct 9, 2019
jillr added a commit to jillr/ansible that referenced this pull request Oct 9, 2019
jillr added a commit to jillr/ansible that referenced this pull request Oct 9, 2019
jillr added a commit to jillr/ansible that referenced this pull request Oct 9, 2019
abadger pushed a commit that referenced this pull request Oct 10, 2019
)

* Fix STS assume role error message when role does not exist (#63249)

AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests

* [2.8] Fix STS assume role error message when role does not exist

* fix changelog sanity
abadger pushed a commit that referenced this pull request Oct 10, 2019
)

* Fix STS assume role error message when role does not exist (#63249)

AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests

* [2.9] Fix STS assume role error message when role does not exist

* fix changelog sanity
samdoran pushed a commit to samdoran/ansible that referenced this pull request Oct 14, 2019
…st (ansible#63249)

AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests
(cherry picked from commit ce402f0)

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
samdoran pushed a commit to samdoran/ansible that referenced this pull request Oct 14, 2019
…st (ansible#63249)

AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests
(cherry picked from commit ce402f0)

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
abadger pushed a commit that referenced this pull request Oct 14, 2019
…st (#63249)

AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests
(cherry picked from commit ce402f0)

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
abadger pushed a commit that referenced this pull request Oct 14, 2019
…st (#63249)

AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests
(cherry picked from commit ce402f0)

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
@jillr jillr deleted the fix_sts_assume_role_tests branch October 23, 2019 20:10
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants