Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for port range to win_firewall_rule_module #63269

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Add example for port range to win_firewall_rule_module #63269

merged 3 commits into from
Oct 21, 2019

Conversation

cossss
Copy link
Contributor

@cossss cossss commented Oct 9, 2019

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY

Sample for opening range of ports.

People often ask me if this is supported because it's not in the docs

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
  • win_firewall_rule_module

@cossss
Update win_firewall_rule.py
29aad86 
##### SUMMARY
Sample for opening range of ports.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@cossss cossss changed the title Update win_firewall_rule.py Add example for port range to win_firewall_rule_module Oct 9, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2019

cc @ShachafGoldstein @timothyvandenbrande @ar7z1 @if-meaton @jborean93 @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 9, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/windows/win_firewall_rule.py:147:1: W293: blank line contains whitespace
lib/ansible/modules/windows/win_firewall_rule.py:156:17: W291: trailing whitespace

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Oct 9, 2019
acozine
acozine reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cossss for adding this example. The suggestions below should fix the whitespace issues and get this PR passing our tests.

lib/ansible/modules/windows/win_firewall_rule.py Outdated Show resolved Hide resolved
lib/ansible/modules/windows/win_firewall_rule.py Outdated Show resolved Hide resolved
@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2019
cossss and others added 2 commits October 15, 2019 15:47
@cossss @acozine
Update lib/ansible/modules/windows/win_firewall_rule.py
e1134dd 
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
@cossss @acozine
Update lib/ansible/modules/windows/win_firewall_rule.py
97b5846 
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 15, 2019
@samccann samccann merged commit 2e81b81 into ansible:devel Oct 21, 2019
@samccann
Copy link
Contributor

Thanks @cossss for the Ansible documentation fix!

acozine pushed a commit to acozine/ansible that referenced this pull request Oct 22, 2019
@cossss @acozine
Add example for port range to win_firewall_rule_module (ansible#63269)
3c1446d 
(cherry picked from commit 2e81b81)
acozine added a commit that referenced this pull request Oct 23, 2019
@acozine
Backport/2.9/docs (#63814)
07fa9b5 
* Replaced old DSC links that given 404 (#63556)
Replace DSC links that returned "not found" with updated, working links.

(cherry picked from commit f638f29)

* Fix example in pip module documentation (#63462)

(cherry picked from commit d8b9f9f)

* Update vmware ansible modules requirements section (#62797)
Update vSphere Automation Python SDK to the requirement section

Signed-off-by: Jobin George <jgeorge@vmware.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 8a77f17)

* Typo usersername should be username (#63671)

(cherry picked from commit 2ef4ac1)

* Update description for firstmatch option (#62896)

Fixes issue #62862. The edit makes the description for the `firstmatch` option clearer. The `firstmatch` option was introduced by PR #33825

(cherry picked from commit aeb0dde)

* Update win_regmerge.py (#63633)
s/windows/Windows/ in title

(cherry picked from commit 4326165)

* Example incorrect: server_url is required argument (#63670)
The example "Delete GitLab Group" does not work - requires server_url parameter. This likely applies to all Examples, so this change proposes at least putting in the required parameter in the examples. In future we can remove the soon-to-be deprecated server_url parameter.

(cherry picked from commit b024679)

* doc: win_user: fix typo in the description of the groups modifyer (#63743)

(cherry picked from commit 6046386)

* Update AWS dev guide to recommend module_defaults and point to CI policy repo (#63589)

(cherry picked from commit 9cda581)

* Add example for port range to win_firewall_rule_module (#63269)

(cherry picked from commit 2e81b81)

* added a link to install instruction of OpenSSH (#63548)

(cherry picked from commit cfe2bea)
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Oct 26, 2019
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cossss @ansibot @samccann @acozine @dagwieers