Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_replication: add channel parameter #63271

Merged
merged 2 commits into from
Oct 9, 2019
Merged

mysql_replication: add channel parameter #63271

merged 2 commits into from
Oct 9, 2019

Conversation

Andersson007
Copy link
Contributor

SUMMARY

mysql_replication: add channel parameter

fixes #29311

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/database/mysql/mysql_replication.py

EXAMPLES
- name: Stop replication in channel master-1
  mysql_replication:
    mode: stopslave
    channel: master-1

@Andersson007 Andersson007 mentioned this pull request Oct 9, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Oct 9, 2019

cc @Alexander198961 @Xyon @banyek @bmalynovytch @bmildren @kurtdavis @michaelcoburn @Oneiroi @tolland
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. database Database category feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. mysql needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Oct 9, 2019
@Andersson007
Copy link
Contributor Author

ready_for_review

@HOSTED-POWER
Copy link

looks good, shipit!

@Andersson007
Copy link
Contributor Author

Andersson007 commented Oct 9, 2019 •
edited

@HOSTED-POWER thank you for review! shipit needs to be in a separate line, would be cool if you add a comment with a standalone shipit inside

@HOSTED-POWER
Copy link

ok sorry :)

shipit

@Andersson007
Copy link
Contributor Author

@HOSTED-POWER thank you!

@gundalow gundalow merged commit 71bcce5 into ansible:devel Oct 9, 2019
@gundalow
Copy link
Contributor

gundalow commented Oct 9, 2019

@Andersson007 Thank you for this feature and tests
@HOSTED-POWER Thank you for your review.

Merged into devel for release in Ansible 2.10

@Andersson007
Copy link
Contributor Author

@gundalow thank you for merging!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 9, 2019
@HOSTED-POWER
Copy link

BTW I can add that we use it in production now, the parts we are using are working properly for sure :)

@Andersson007
Copy link
Contributor Author

@HOSTED-POWER thanks for the feedback! :)

@Andersson007
Copy link
Contributor Author

@HOSTED-POWER #63547 please look, probably it could be interesting for someone who use MySQL

@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. database Database category feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. mysql support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysql_replication: feature - Support Multi-Source Replication
5 participants
@Andersson007 @ansibot @HOSTED-POWER @gundalow @sivel