mysql_info: change order of collecting and filtering items

[the02]

SUMMARY

collect data based on the filters

ISSUE TYPE

• Feature Idea

COMPONENT NAME

mysql_info

ADDITIONAL INFORMATION

On large databases mysql_info runs very long due to size calculations of all db/tables even when this information is not needed (for example quering user information only)

[ansibot]

Files identified in the description:

• lib/ansible/modules/database/mysql/mysql_info.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @Alexander198961 @Andersson007 @Xyon @bmalynovytch @bmildren @kurtdavis @michaelcoburn @Oneiroi @tolland
click here for bot help

[Andersson007]

@the02 hello, thank you for the feedback.
I suggest adding a flag, e.g. db_size: yes | no
What, guys, do you think? Any other ideas?
@bmalynovytch

[bmalynovytch]

Maybe something more general like included_fields with a default to ALL, which would allow to filter out some fields.

[Andersson007]

What if we need all fields except db sizes? i agree, it can be annoying to wait for one field.
In general sounds good. Maybe exclude_fields?

[Andersson007]

Or maybe both? And we could make them mutually exclusive

[Andersson007]

Ok, i got the hint :) will try to implement one of them tomorrow. Then the another one If success

[Andersson007]

resolved_by_pr: #63371

[the02]

sorry for the late reply, has been a very busy day yesterday.
Maybe I would have solved it without an extra key, but this solution is also a good idea, maybe better than using ! for exclusion

[Andersson007]

@tHe2 thank you for reporting this!
would be cool if you look at the PR and, if it is ok for you, add a comment with:
shipit
or any suggestions

[the02]

@Andersson007 will take a look at it tonight how it performs on large databases.

[Andersson007]

@the02 thank you! Would be really good