Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_image: fix option parameter so that warnings are issued #63345

Merged
merged 2 commits into from Oct 12, 2019
Merged

docker_image: fix option parameter so that warnings are issued #63345

merged 2 commits into from Oct 12, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

@resmo commented here that the docker_image module uses removedin_version instead of removed_in_version in argument spec, which caused some deprecation warnings to not being shown.

The affected options are container_limits, dockerfile, http_timeout, nocache, path, pull, rm and buildargs.

Since there is code in https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/docker/docker_image.py#L908-L931 which checks for these options being set, and emits a warning in case they are that they have been renamed and will be removed in 2.12, it should be fine to just fix this typo.

CC @resmo @abadger

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_image

@ansibot
Copy link
Contributor

ansibot commented Oct 10, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @danihodovic @dariko @jwitko @kassiansun @softzilla @ssbarnea @tbouvet
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 10, 2019
@felixfontein felixfontein mentioned this pull request Oct 10, 2019
Merged
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 10, 2019
resmo
resmo approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Oct 12, 2019
@ansibot ansibot merged commit 61b3784 into ansible:devel Oct 12, 2019
@felixfontein felixfontein deleted the docker_image-fix-option-typos branch October 12, 2019 12:09
felixfontein added a commit to felixfontein/ansible that referenced this pull request Oct 12, 2019
@felixfontein
docker_image: fix option parameter so that warnings are issued (ansib…
c04a475 
…le#63345)

* Fix option parameter so that warnings are issued.

* Add changelog.

(cherry picked from commit 61b3784)
felixfontein added a commit to felixfontein/ansible that referenced this pull request Oct 12, 2019
@felixfontein
docker_image: fix option parameter so that warnings are issued (ansib…
78779e4 
…le#63345)

* Fix option parameter so that warnings are issued.

* Add changelog.

(cherry picked from commit 61b3784)
This was referenced Oct 12, 2019
Merged
Merged
@felixfontein
Copy link
Contributor Author

@resmo thanks a lot for spotting this, and for reviewing!

abadger pushed a commit that referenced this pull request Oct 12, 2019
@felixfontein @abadger
docker_image: fix option parameter so that warnings are issued (#63345)
006156d 
* Fix option parameter so that warnings are issued.

* Add changelog.

(cherry picked from commit 61b3784)
abadger pushed a commit that referenced this pull request Oct 12, 2019
@felixfontein @abadger
docker_image: fix option parameter so that warnings are issued (#63345)
8b729d3 
* Fix option parameter so that warnings are issued.

* Add changelog.

(cherry picked from commit 61b3784)
abadger pushed a commit that referenced this pull request Nov 1, 2019
@felixfontein @abadger
docker_image: fix option parameter so that warnings are issued (#63345)
353c9cb 
* Fix option parameter so that warnings are issued.

* Add changelog.

(cherry picked from commit 61b3784)
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixfontein @ansibot @resmo