Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_variables: add seealso, add return value #63442

Merged
merged 1 commit into from
Oct 14, 2019
Merged

mysql_variables: add seealso, add return value #63442

merged 1 commit into from
Oct 14, 2019

Conversation

Andersson007
Copy link
Contributor

@Andersson007 Andersson007 commented Oct 14, 2019 •
edited

SUMMARY

mysql_variable:

  1. add see also
  2. change doc formatting
  3. add return value
  4. fix examples
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/database/mysql/mysql_variables.py

@ansibot
Copy link
Contributor

ansibot commented Oct 14, 2019

cc @Alexander198961 @Xyon @banyek @bmalynovytch @bmildren @kurtdavis @michaelcoburn @Oneiroi @tolland
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. database Database category docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. mysql needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Oct 14, 2019
@Andersson007
Copy link
Contributor Author

ready_for_review

gundalow
gundalow approved these changes Oct 14, 2019
View reviewed changes
lib/ansible/modules/database/mysql/mysql_variables.py
EXAMPLES = r'''
- name: Check for sync_binlog setting
- mysql_variables:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

@gundalow gundalow merged commit 0ca6823 into ansible:devel Oct 14, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 14, 2019
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. database Database category docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. mysql support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andersson007 @ansibot @gundalow @sivel