Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize on_become prompt match for ios #63528

Merged
merged 1 commit into from
Oct 16, 2019
Merged

generalize on_become prompt match for ios #63528

merged 1 commit into from
Oct 16, 2019

Conversation

benjdudas
Copy link
Contributor

SUMMARY

Fixing a customer-related issue.

Modify regex to compare more generic which will help in situations where TACACS is returning an unexpected password prompt. (i.e. ADS_ID_password:)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/terminal/ios.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 15, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community needs_triage Needs a first human triage before being processed. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Oct 15, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 15, 2019

Build succeeded (third-party-check pipeline).

@justjais justjais merged commit 88013e7 into ansible:devel Oct 16, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 16, 2019
falcon78921 pushed a commit to falcon78921/ansible that referenced this pull request Oct 17, 2019
@benjdudas @falcon78921
[stable-2.9] generalized on_become prompt match for ios (ansible#63528)
b90a621 
(cherry picked from commit 88013e7)
@falcon78921 falcon78921 mentioned this pull request Oct 17, 2019
Closed
@benjdudas benjdudas mentioned this pull request Nov 6, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justjais justjais justjais approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjdudas @ansibot @justjais @sivel