Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added module to manage template external epg subnet for Cisco MSO #63542

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Added module to manage template external epg subnet for Cisco MSO #63542

merged 2 commits into from
Oct 22, 2019

Conversation

devarshishah3
Copy link
Contributor

SUMMARY

Added a module to manage template external EPG subnet for Cisco Multisite Orch.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

mso_schema_template_external_epg_subnet.py

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2019

cc @brunocalogero @dagwieers @fadallar @jmcgill298 @koladiya @mtorelli @rsmeyers @schunduri @smnmtzgr
click here for bot help

@ansibot ansibot added aci Cisco ACI community affects_2.10 This issue/PR affects Ansible v2.10 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 16, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/aci/mso_schema_template_external_epg_subnet.py:0:0: module-incorrect-version-added: version_added should be '2.10'. Currently '2.9'
lib/ansible/modules/network/aci/mso_schema_template_external_epg_subnet.py:0:0: nonexistent-parameter-documented: Argument 'ip' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/network/aci/mso_schema_template_external_epg_subnet.py:178:83: bad-whitespace: Exactly one space required after comma         subnet_path = '/templates/{0}/externalEpgs/{1}/subnets/{2}'.format(template,external_epg, subnet_idx)                                                                                    ^
lib/ansible/modules/network/aci/mso_schema_template_external_epg_subnet.py:188:76: bad-whitespace: Exactly one space required after comma     subnets_path = '/templates/{0}/externalEpgs/{1}/subnets'.format(template,external_epg)                                                                             ^

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/network/aci/mso_schema_template_external_epg_subnet.py:178:84: E231: missing whitespace after ','
lib/ansible/modules/network/aci/mso_schema_template_external_epg_subnet.py:188:77: E231: missing whitespace after ','

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. ci_verified Changes made in this PR are causing tests to fail. labels Oct 16, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2019

@brunocalogero @fadallar @jasonjuenger @jmcgill298 @koladiya @mtorelli @nkatarmal-crest @rost-d @rsmeyers @schunduri @sgerhart @smnmtzgr @tknipper11

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 16, 2019
dagwieers
dagwieers reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dagwieers
dagwieers approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Oct 22, 2019
@dagwieers dagwieers merged commit 2b1177d into ansible:devel Oct 22, 2019
@ansible ansible locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.10 This issue/PR affects Ansible v2.10 cisco Cisco technologies module This issue/PR relates to a module. networking Network category new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devarshishah3 @ansibot @dagwieers