Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_variables tests: change CI host group #63602

Merged
merged 1 commit into from
Oct 17, 2019
Merged

mysql_variables tests: change CI host group #63602

merged 1 commit into from
Oct 17, 2019

Conversation

Andersson007
Copy link
Contributor

SUMMARY

mysql_variables tests: change CI host group
fixes #63590
fixes #63592

it is related to attempt to install MySQL servers of different versions but it is needed for development.
The first installation installs libraries which conflict with the newest.

gradually i'll move all tests to MySQL 8.0

ISSUE TYPE
  • Bugfix Pull Request

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2019

cc @Alexander198961 @Xyon @banyek @bmalynovytch @bmildren @kurtdavis @michaelcoburn @Oneiroi @tolland
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. database Database category mysql needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Oct 17, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Oct 17, 2019
@felixfontein felixfontein merged commit d615d7e into ansible:devel Oct 17, 2019
@samdoran
Copy link
Contributor

This is not a reliable fix. If tests are interfering with each other, that's a sign they are not properly cleaning up the packages they install. In the case of setup_mysql_db and setup_mysql8, we should add handlers that remove the packages they install, similar to what is done in setup_mongodb.

@Andersson007
Copy link
Contributor Author

@samdoran it can be a challenge to remove all dependencies. Anyway i’m going to move all tests to mysql 8

@ansible ansible locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. database Database category mysql support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup_mysql8 integration test role fails when run with the test group
4 participants
@Andersson007 @ansibot @samdoran @felixfontein