Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo usersername should be username #63671

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Typo usersername should be username #63671

merged 1 commit into from
Oct 18, 2019

Conversation

herpus-derpus
Copy link
Contributor

SUMMARY

Typo in examples using api_username. Example incorrectly has usersername.

ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY

Typo in examples using api_username. Example incorrectly has usersername.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

gitlab_group

ADDITIONAL INFORMATION

@herpus-derpus
Typo usersername should be username
db87f6b 
##### SUMMARY
Typo in examples using api_username. Example incorrectly has usersername.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Oct 18, 2019

cc @Lunik @Shaps @dj-wasabi @jlozadad @marwatk @waheedi
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. gitlab Gitlab community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community. labels Oct 18, 2019
gundalow
gundalow approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thank you.

Your first PR to Ansible Merged.

Hopefully first of many!

@gundalow gundalow merged commit 2ef4ac1 into ansible:devel Oct 18, 2019
@gundalow gundalow added this to Needs Triage - todo backlog - Docsite work -anything can go here in Ansible-maintained Collections Documentation via automation Oct 18, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 22, 2019
acozine pushed a commit to acozine/ansible that referenced this pull request Oct 22, 2019
@herpus-derpus @acozine
Typo usersername should be username (ansible#63671)
88fcb8e 
##### SUMMARY
Typo in examples using api_username. Example incorrectly has usersername.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

(cherry picked from commit 2ef4ac1)
acozine added a commit that referenced this pull request Oct 23, 2019
@acozine
Backport/2.9/docs (#63814)
07fa9b5 
* Replaced old DSC links that given 404 (#63556)
Replace DSC links that returned "not found" with updated, working links.

(cherry picked from commit f638f29)

* Fix example in pip module documentation (#63462)

(cherry picked from commit d8b9f9f)

* Update vmware ansible modules requirements section (#62797)
Update vSphere Automation Python SDK to the requirement section

Signed-off-by: Jobin George <jgeorge@vmware.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 8a77f17)

* Typo usersername should be username (#63671)

(cherry picked from commit 2ef4ac1)

* Update description for firstmatch option (#62896)

Fixes issue #62862. The edit makes the description for the `firstmatch` option clearer. The `firstmatch` option was introduced by PR #33825

(cherry picked from commit aeb0dde)

* Update win_regmerge.py (#63633)
s/windows/Windows/ in title

(cherry picked from commit 4326165)

* Example incorrect: server_url is required argument (#63670)
The example "Delete GitLab Group" does not work - requires server_url parameter. This likely applies to all Examples, so this change proposes at least putting in the required parameter in the examples. In future we can remove the soon-to-be deprecated server_url parameter.

(cherry picked from commit b024679)

* doc: win_user: fix typo in the description of the groups modifyer (#63743)

(cherry picked from commit 6046386)

* Update AWS dev guide to recommend module_defaults and point to CI policy repo (#63589)

(cherry picked from commit 9cda581)

* Add example for port range to win_firewall_rule_module (#63269)

(cherry picked from commit 2e81b81)

* added a link to install instruction of OpenSSH (#63548)

(cherry picked from commit cfe2bea)
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Oct 26, 2019
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. gitlab Gitlab community module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch source_control Source-control category support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
Ansible-maintained Collections Docume...
  
Needs Triage - todo backlog --anythin...
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@herpus-derpus @ansibot @gundalow @sivel @dagwieers