Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement run_commands on edgeos #63754

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Implement run_commands on edgeos #63754

merged 1 commit into from
Oct 21, 2019

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Oct 21, 2019

SUMMARY

run_commands() adds a little flexibility with following vyos

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

edgeos

@ansibot
Copy link
Contributor

ansibot commented Oct 21, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/cliconf/edgeos.py:86:19: undefined-variable: Undefined variable 'AnsibleConnectionFailure'

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 21, 2019
@Qalthos Qalthos merged commit ae8aa05 into ansible:devel Oct 21, 2019
@Qalthos Qalthos deleted the edge_run branch October 21, 2019 20:01
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 22, 2019
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. networking Network category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Qalthos @ansibot @sivel