Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.8] lineinfile - use correct index value when inserting at the end (#63696) #63795

Merged
merged 1 commit into from Nov 12, 2019
Merged

[stable-2.8] lineinfile - use correct index value when inserting at the end (#63696) #63795

merged 1 commit into from Nov 12, 2019

Conversation

samdoran
Copy link
Contributor

SUMMARY

Backport of #63696 for Ansible 2.8
(cherry picked from commit 92cd13a)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/files/lineinfile.py

@samdoran
[stable-2.8] lineinfile - use correct index value when inserting at t…
1a760bb 
…he end (ansible#63696)

(cherry picked from commit 92cd13a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Oct 22, 2019

cc @ahtik @dhozac
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 22, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 30, 2019
@mattclay mattclay added the backport_verified This PR has been verified as a backport of a merged devel PR. label Nov 6, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 6, 2019
@nitzmahone nitzmahone merged commit f861c28 into ansible:stable-2.8 Nov 12, 2019
@ansible ansible locked and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport_verified This PR has been verified as a backport of a merged devel PR. backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samdoran @ansibot @mattclay @nitzmahone