Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network plugin config option load from collection #64046

Merged
merged 2 commits into from Nov 1, 2019
Merged

Fix network plugin config option load from collection #64046

merged 2 commits into from Nov 1, 2019

Conversation

ganeshrn
Copy link
Member

SUMMARY

Fixes #63975

  • Update the complete sub-plugin name within network
    connection plugins to handle sub-plugin in collection
    scenario.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/connection/httpapi.py
plugins/connection/netconf.py
plugins/connection/network_cli.py

ADDITIONAL INFORMATION

@ganeshrn ganeshrn requested a review from Qalthos October 29, 2019 05:50
@ansibot
Copy link
Contributor

ansibot commented Oct 29, 2019

cc @NilashishC @Qalthos @danielmellado @justjais @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 29, 2019
@ansible ansible deleted a comment from ansible-zuul bot Oct 29, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 29, 2019
@ganeshrn
Fix network plugin config option load from collection
28a028f 
Fixes ansible#63975

* Update the complete sub-plugin name within network
  connection plugins to handle sub-plugin in collection
  scenario.
@ansible ansible deleted a comment from ansible-zuul bot Oct 29, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 29, 2019

Build succeeded (third-party-check pipeline).

@justjais justjais removed the needs_triage Needs a first human triage before being processed. label Oct 30, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Oct 31, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 31, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Oct 31, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ganeshrn
Copy link
Member Author

recheck

@ansible-zuul
Copy link

ansible-zuul bot commented Oct 31, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ganeshrn
Copy link
Member Author

ganeshrn commented Nov 1, 2019

Failure not related to changes in PR

@ganeshrn ganeshrn merged commit 60276d3 into ansible:devel Nov 1, 2019
ganeshrn added a commit to ganeshrn/ansible that referenced this pull request Nov 1, 2019
@ganeshrn
Fix network plugin config option load from collection (ansible#64046)
9f47ed4 
* Fix network plugin config option load from collection

Fixes ansible#63975

* Update the complete sub-plugin name within network
  connection plugins to handle sub-plugin in collection
  scenario.

* Fix review comments

(cherry picked from commit 60276d3)
@ganeshrn ganeshrn mentioned this pull request Nov 1, 2019
Merged
ganeshrn added a commit to ganeshrn/ansible that referenced this pull request Nov 1, 2019
@ganeshrn
Fix network plugin config option load from collection (ansible#64046)
166e583 
* Fix network plugin config option load from collection

Fixes ansible#63975

* Update the complete sub-plugin name within network
  connection plugins to handle sub-plugin in collection
  scenario.

* Fix review comments

(cherry picked from commit 60276d3)
mattclay pushed a commit that referenced this pull request Nov 12, 2019
@ganeshrn @mattclay
Fix network plugin config option load from collection (#64046)
5a2d55a 
* Fix network plugin config option load from collection

Fixes #63975

* Update the complete sub-plugin name within network
  connection plugins to handle sub-plugin in collection
  scenario.

* Fix review comments

(cherry picked from commit 60276d3)
@ansible ansible locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justjais justjais justjais approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use vars in playbook when using collections
3 participants
@ganeshrn @ansibot @justjais